hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: CG trace: Handle subscript

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2020-07-21 21:45:53 +02:00
parent 79c2c682d7
commit 61b1d3eef3
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
python/tools/recorded-call-graph-metrics/example/__getitem__.py Normal file
View File

@@ -0,0 +1,7 @@
class Foo:
def __getitem__(self, key):
print("__getitem__")
foo = Foo()
foo["key"] # this is recorded as a call :)

14
python/tools/recorded-call-graph-metrics/src/cg_trace/bytecode_reconstructor.py
View File

@@ -45,6 +45,15 @@ class BytecodeAttribute(BytecodeExpr):
return f"{self.object}.{self.attr_name}" return f"{self.object}.{self.attr_name}"
@dataclasses.dataclass(frozen=True, eq=True, order=True)
class BytecodeSubscript(BytecodeExpr):
key: BytecodeExpr
object: BytecodeExpr
def __str__(self):
return f"{self.object}[{self.key}]"
@dataclasses.dataclass(frozen=True, eq=True, order=True) @dataclasses.dataclass(frozen=True, eq=True, order=True)
class BytecodeCall(BytecodeExpr): class BytecodeCall(BytecodeExpr):
function: BytecodeExpr function: BytecodeExpr
@@ -147,6 +156,11 @@ def expr_from_instruction(instructions: List[Instruction], index: int) -> Byteco
obj_expr = expr_that_added_elem_to_stack(instructions, index - 1, 0) obj_expr = expr_that_added_elem_to_stack(instructions, index - 1, 0)
return BytecodeAttribute(attr_name=attr_name, object=obj_expr) return BytecodeAttribute(attr_name=attr_name, object=obj_expr)
elif inst.opname in ["BINARY_SUBSCR"]:
key_expr = expr_that_added_elem_to_stack(instructions, index - 1, 0)
obj_expr = expr_that_added_elem_to_stack(instructions, index - 1, 1)
return BytecodeSubscript(key=key_expr, object=obj_expr)
# https://docs.python.org/3/library/dis.html#opcode-CALL_FUNCTION # https://docs.python.org/3/library/dis.html#opcode-CALL_FUNCTION
elif inst.opname in ["CALL_FUNCTION", "CALL_METHOD", "CALL_FUNCTION_KW"]: elif inst.opname in ["CALL_FUNCTION", "CALL_METHOD", "CALL_FUNCTION_KW"]:
assert index > 0 assert index > 0