hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-19 22:14:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
This commit is contained in:
Jeroen Ketema
2023-11-10 13:55:39 +01:00
committed by GitHub
parent 1c87875049
commit 617d950a25
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/lib/semmle/code/cpp/models/implementations/Strcat.qll
View File

@@ -104,7 +104,7 @@ class StrlcatFunction extends TaintFunction, ArrayFunction, SideEffectFunction {
/**
* Gets the index of the parameter that is the size of the copy (in characters).
*/
int getParamSize() { exists(this.getParameter(2)) and result = 2 }
int getParamSize() { result = 2 }
/**
* Gets the index of the parameter that is the source of the copy.

2
cpp/ql/lib/semmle/code/cpp/models/implementations/Strcpy.qll
View File

@@ -32,7 +32,7 @@ class StrcpyFunction extends ArrayFunction, DataFlowFunction, TaintFunction, Sid
"wcsxfrm_l", // _strxfrm_l(dest, src, max_amount, locale)
"_mbsnbcpy", // _mbsnbcpy(dest, src, max_amount)
"stpcpy", // stpcpy(dest, src)
"stpncpy", // stpcpy(dest, src, max_amount)
"stpncpy", // stpncpy(dest, src, max_amount)
"strlcpy" // strlcpy(dst, src, dst_size)
])
or