hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java/C#/Go/Swift: remove commented-out code

Browse Source
This commit is contained in:
Jami Cogswell
2023-06-02 16:57:24 -04:00
parent 9f42ae3f29
commit 615f2a573b
4 changed files with 0 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll
View File

@@ -313,22 +313,11 @@ module ModelValidation {
private string getInvalidModelKind() {
exists(string kind | summaryModel(_, _, _, _, _, _, _, _, kind, _) |
not kind instanceof ValidSummaryKind and
//not kind = ["taint", "value"] and
result = "Invalid kind \"" + kind + "\" in summary model."
)
or
exists(string kind, string msg | sinkModel(_, _, _, _, _, _, _, kind, _) |
not kind instanceof ValidSinkKind and
// not kind =
// [
// "request-forgery", "jndi-injection", "ldap-injection", "sql-injection", "log-injection",
// "mvel-injection", "xpath-injection", "groovy-injection", "html-injection", "js-injection",
// "ognl-injection", "intent-redirection", "pending-intents", "url-redirection",
// "path-injection", "file-content-store", "hostname-verification", "response-splitting",
// "information-leak", "xslt-injection", "jexl-injection", "bean-validation",
// "template-injection", "fragment-injection", "command-injection"
// ] and
not kind.matches("regex-use%") and
not kind.matches("qltest%") and
msg = "Invalid kind \"" + kind + "\" in sink model." and
// The part of this message that refers to outdated sink kinds can be deleted after June 1st, 2024.
@@ -339,14 +328,12 @@ module ModelValidation {
or
exists(string kind | sourceModel(_, _, _, _, _, _, _, kind, _) |
not kind instanceof ValidSourceKind and
// not kind = ["remote", "contentprovider", "android-widget", "android-external-storage-dir"] and
not kind.matches("qltest%") and
result = "Invalid kind \"" + kind + "\" in source model."
)
or
exists(string kind | neutralModel(_, _, _, _, kind, _) |
not kind instanceof ValidNeutralKind and
//not kind = ["summary", "source", "sink"] and
result = "Invalid kind \"" + kind + "\" in neutral model."
)
}