From 60e7786b04ba2567e328f253d8cf3cc94947d863 Mon Sep 17 00:00:00 2001 From: Rasmus Wriedt Larsen Date: Mon, 23 Oct 2023 16:44:54 +0200 Subject: [PATCH] Python: Use explicit keyword parameter --- .../frameworks/rest_framework/taint_test.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/python/ql/test/library-tests/frameworks/rest_framework/taint_test.py b/python/ql/test/library-tests/frameworks/rest_framework/taint_test.py index 83b5429437e..66167a75539 100644 --- a/python/ql/test/library-tests/frameworks/rest_framework/taint_test.py +++ b/python/ql/test/library-tests/frameworks/rest_framework/taint_test.py @@ -112,18 +112,19 @@ class MyClass(APIView): # see https://www.django-rest-framework.org/api-guide/viewsets/ class MyModelViewSet(ModelViewSet): - def retrieve(self, request, *args, **kwargs): # $ requestHandler + def retrieve(self, request, routed_param): # $ requestHandler routedParameter=routed_param ensure_tainted( request, # $ tainted request.GET, # $ tainted request.GET.get("pk"), # $ tainted + request.data # $ tainted ) - ensure_tainted( - kwargs, # $ tainted - kwargs["pk"], # $ tainted - kwargs.get("pk"), # $ tainted - ) + ensure_tainted(routed_param) # $ tainted + + # same as for standard Django view + ensure_tainted(self.args, self.kwargs) # $ tainted + return Response("retrieve") # $ HttpResponse