From 60c70036676257a535442a802270759dfd91ce70 Mon Sep 17 00:00:00 2001
From: Benjamin Muskalla <bmuskalla@github.com>
Date: Mon, 2 Aug 2021 16:13:48 +0200
Subject: [PATCH] Optimize return type check

---
 java/ql/src/Telemetry/ExternalAPI.qll | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/java/ql/src/Telemetry/ExternalAPI.qll b/java/ql/src/Telemetry/ExternalAPI.qll
index c1787ee1f39..b665bbb7fec 100644
--- a/java/ql/src/Telemetry/ExternalAPI.qll
+++ b/java/ql/src/Telemetry/ExternalAPI.qll
@@ -9,10 +9,10 @@ class ExternalAPI extends Callable {
 
   predicate isInteresting() {
     getNumberOfParameters() > 0 and
-    not (
-      getReturnType() instanceof VoidType or
-      getReturnType() instanceof PrimitiveType or
-      getReturnType() instanceof BoxedType
+    exists(Type retType | retType = getReturnType() |
+      not retType instanceof VoidType and
+      not retType instanceof PrimitiveType and
+      not retType instanceof BoxedType
     )
   }