hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 12:46:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix code review findings in 'endregion' directives

Browse Source
This commit is contained in:
Tamas Vajk
2021-01-26 16:03:43 +01:00
parent 6ef8e51bcf
commit 60b23dc505
3 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
csharp/ql/src/semmle/code/csharp/Preprocessor.qll
View File

@@ -240,11 +240,11 @@ class RegionDirective extends PreprocessorDirective, @directive_region {
}
/**
* A `#endregion` directive.
* An `#endregion` directive.
*/
class EndRegionDirective extends PreprocessorDirective, @directive_endregion {
/** Gets the opening `#region` directive. */
RegionDirective getStart() { regions(result, this) }
RegionDirective getStart() { result.getEnd() = this }
override string toString() { result = "#endregion" }

4
csharp/ql/test/library-tests/comments/RegionDirectives.expected
View File

@@ -1,6 +1,2 @@
regionDirectives
| trivia.cs:36:9:36:22 | #region ... | fields | trivia.cs:41:9:41:18 | #endregion |
| trivia.cs:38:9:38:22 | #region ... | nested | trivia.cs:40:9:40:18 | #endregion |
endregions
| trivia.cs:40:9:40:18 | #endregion | trivia.cs:38:9:38:22 | #region ... |
| trivia.cs:41:9:41:18 | #endregion | trivia.cs:36:9:36:22 | #region ... |

2
csharp/ql/test/library-tests/comments/RegionDirectives.ql
View File

@@ -4,5 +4,3 @@ query predicate regionDirectives(RegionDirective d, string name, EndRegionDirect
d.getName() = name and
d.getEnd() = end
}
query predicate endregions(EndRegionDirective d, RegionDirective start) { d.getStart() = start }