C#/C++: Share IR implementation

cpp/ql/src/semmle/code/cpp/ir/implementation/Opcode.qll

@@ -42,6 +42,7 @@ private newtype TOpcode =
   TDynamicCastToVoid() or
   TVariableAddress() or
   TFieldAddress() or
+  TIndexedElementAddress() or
   TFunctionAddress() or
   TConstant() or
   TStringConstant() or
@@ -190,6 +191,7 @@ module Opcode {
   class DynamicCastToVoid extends UnaryOpcode, TDynamicCastToVoid { override final string toString() { result = "DynamicCastToVoid" } }
   class VariableAddress extends Opcode, TVariableAddress { override final string toString() { result = "VariableAddress" } }
   class FieldAddress extends UnaryOpcode, TFieldAddress { override final string toString() { result = "FieldAddress" } }
+  class IndexedElementAddress extends BinaryOpcode, TIndexedElementAddress { override final string toString() { result = "IndexedElementAddress" } }
   class FunctionAddress extends Opcode, TFunctionAddress { override final string toString() { result = "FunctionAddress" } }
   class Constant extends Opcode, TConstant { override final string toString() { result = "Constant" } }
   class StringConstant extends Opcode, TStringConstant { override final string toString() { result = "StringConstant" } }

cpp/ql/src/semmle/code/cpp/ir/implementation/TempVariableTag.qll

@@ -1,4 +1,5 @@
-private import semmle.code.cpp.ir.internal.TempVariableTag
+private import internal.TempVariableTagInternal
+private import Imports::TempVariableTag
 
 class TempVariableTag extends TTempVariableTag {
   string toString() {

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll

@@ -512,7 +512,7 @@ class Instruction extends Construction::TInstruction {
     else if getResultType() instanceof Language::UnknownType then
       result = Construction::getInstructionResultSize(this)
     else (
-      result = getResultType().getSize()
+      result = Language::getTypeSize(getResultType())
     )
   }
 

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Operand.qll

@@ -186,7 +186,7 @@ class Operand extends TOperand {
    * a known constant size, this predicate does not hold.
    */
   int getSize() {
-    result = getType().getSize()
+    result = Language::getTypeSize(getType())
   }
 }
 
@@ -450,7 +450,7 @@ class SideEffectOperand extends TypedOperand {
     if getType() instanceof Language::UnknownType then
       result = Construction::getInstructionOperandSize(useInstr, tag)
     else
-      result = getType().getSize()
+      result = Language::getTypeSize(getType())
   }
 
   override MemoryAccessKind getMemoryAccess() {

cpp/ql/src/semmle/code/cpp/ir/implementation/internal/TempVariableTagInternal.qll

@@ -0,0 +1,6 @@
+import semmle.code.cpp.ir.internal.IRCppLanguage as Language
+private import semmle.code.cpp.ir.internal.TempVariableTag as TempVariableTag_
+
+module Imports {
+  module TempVariableTag = TempVariableTag_;
+}

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll

@@ -512,7 +512,7 @@ class Instruction extends Construction::TInstruction {
     else if getResultType() instanceof Language::UnknownType then
       result = Construction::getInstructionResultSize(this)
     else (
-      result = getResultType().getSize()
+      result = Language::getTypeSize(getResultType())
     )
   }
 

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Operand.qll

@@ -186,7 +186,7 @@ class Operand extends TOperand {
    * a known constant size, this predicate does not hold.
    */
   int getSize() {
-    result = getType().getSize()
+    result = Language::getTypeSize(getType())
   }
 }
 
@@ -450,7 +450,7 @@ class SideEffectOperand extends TypedOperand {
     if getType() instanceof Language::UnknownType then
       result = Construction::getInstructionOperandSize(useInstr, tag)
     else
-      result = getType().getSize()
+      result = Language::getTypeSize(getType())
   }
 
   override MemoryAccessKind getMemoryAccess() {

cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll

@@ -512,7 +512,7 @@ class Instruction extends Construction::TInstruction {
     else if getResultType() instanceof Language::UnknownType then
       result = Construction::getInstructionResultSize(this)
     else (
-      result = getResultType().getSize()
+      result = Language::getTypeSize(getResultType())
     )
   }
 

cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Operand.qll

@@ -186,7 +186,7 @@ class Operand extends TOperand {
    * a known constant size, this predicate does not hold.
    */
   int getSize() {
-    result = getType().getSize()
+    result = Language::getTypeSize(getType())
   }
 }
 
@@ -450,7 +450,7 @@ class SideEffectOperand extends TypedOperand {
     if getType() instanceof Language::UnknownType then
       result = Construction::getInstructionOperandSize(useInstr, tag)
     else
-      result = getType().getSize()
+      result = Language::getTypeSize(getType())
   }
 
   override MemoryAccessKind getMemoryAccess() {

cpp/ql/src/semmle/code/cpp/ir/internal/IRCppLanguage.qll

@@ -52,6 +52,10 @@ predicate hasAsmOperandIndex(int operandIndex) {
   )
 }
 
+int getTypeSize(Type type) {
+  result = type.getSize()
+}
+
 int getPointerSize() {
   exists(Cpp::NullPointerType nullptr |
     result = nullptr.getSize()