hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-23 15:55:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

update js/nested-loops-with-same-variable to match cpp

Browse Source
This commit is contained in:
erik-krogh
2022-08-11 22:36:00 +02:00
parent 20625ae60d
commit 60908de089
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
javascript/ql/src/Statements/NestedLoopsSameVariable.ql
View File

@@ -15,16 +15,17 @@ import javascript
/**
* Gets an iteration variable that loop `for` tests and updates.
*/
Variable getAnIterationVariable(ForStmt for) {
Variable getAnIterationVariable(ForStmt for, Expr upAccess) {
result.getAnAccess().getParentExpr*() = for.getTest() and
exists(UpdateExpr upd | upd.getParentExpr*() = for.getUpdate() |
upd.getOperand() = result.getAnAccess()
upAccess = upd.getOperand() and upAccess = result.getAnAccess()
)
}
from ForStmt outer, ForStmt inner
from ForStmt outer, ForStmt inner, Variable iteration, Expr upAccess
where
inner.nestedIn(outer) and
getAnIterationVariable(outer) = getAnIterationVariable(inner)
select inner.getTest(), "This for statement uses the same loop variable as an enclosing $@.", outer,
"for statement"
iteration = getAnIterationVariable(outer, _) and
iteration = getAnIterationVariable(inner, upAccess)
select inner.getTest(), "Nested for statement uses loop variable $@ of enclosing $@.", upAccess,
iteration.getName(), outer, "for statement"