hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 11:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Autoformats

Browse Source
This commit is contained in:
Rebecca Valentine
2020-03-10 08:08:05 -07:00
parent 4eb3de2aca
commit 6017197870
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
python/ql/src/Functions/SignatureOverriddenMethod.ql
View File

@@ -6,7 +6,6 @@
* @problem.severity warning
* @tags reliability
* correctness
* @problem.severity warning
* @sub-severity high
* @precision very-high
* @id py/inheritance/signature-mismatch
@@ -19,8 +18,8 @@ from FunctionValue base, PythonFunctionValue derived
where
not exists(base.getACall()) and
not exists(FunctionValue a_derived |
a_derived.overrides(base) and
exists(a_derived.getACall())
a_derived.overrides(base) and
exists(a_derived.getACall())
) and
not derived.getScope().isSpecialMethod() and
derived.getName() != "__init__" and
@@ -28,8 +27,9 @@ where
not derived.getScope().isSpecialMethod() and
// call to overrides distributed for efficiency
(
(derived.overrides(base) and derived.minParameters() > base.maxParameters())
derived.overrides(base) and derived.minParameters() > base.maxParameters()
or
(derived.overrides(base) and derived.maxParameters() < base.minParameters())
derived.overrides(base) and derived.maxParameters() < base.minParameters()
)
select derived, "Overriding method '" + derived.getName() + "' has signature mismatch with $@.", base, "overridden method"
select derived, "Overriding method '" + derived.getName() + "' has signature mismatch with $@.",
base, "overridden method"