hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

convert paramiko query to SecondaryServerCmdInjection query, Add inline tests

Browse Source
This commit is contained in:
amammad
2024-02-24 18:09:43 +04:00
committed by Taus
parent 6520e2fdfb
commit 5fea71e5d6
10 changed files with 52 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
python/ql/test/experimental/query-tests/Security/CWE-074-SecondaryServerCmdInjection/DataflowQueryTest.expected Normal file
View File

@@ -0,0 +1,3 @@
missingAnnotationOnSink
testFailures
failures

4
python/ql/test/experimental/query-tests/Security/CWE-074-SecondaryServerCmdInjection/DataflowQueryTest.ql Normal file
View File

@@ -0,0 +1,4 @@
import python
import experimental.dataflow.TestUtil.DataflowQueryTest
import experimental.semmle.python.security.SecondaryServerCmdInjection
import FromTaintTrackingConfig<ParamikoConfig>

0
python/ql/test/experimental/query-tests/Security/CWE-074-paramiko/paramiko.expected → python/ql/test/experimental/query-tests/Security/CWE-074-SecondaryServerCmdInjection/SecondaryServerCmdInjection.expected
View File

1
python/ql/test/experimental/query-tests/Security/CWE-074-SecondaryServerCmdInjection/SecondaryServerCmdInjection.qlref Normal file
View File

@@ -0,0 +1 @@
experimental/Security/CWE-074/secondaryCommandInjection/SecondaryServerCmdInjection.ql

6
python/ql/test/experimental/query-tests/Security/CWE-074-paramiko/paramiko.py → python/ql/test/experimental/query-tests/Security/CWE-074-SecondaryServerCmdInjection/paramiko.py
View File

@@ -13,15 +13,15 @@ app = FastAPI()
@app.get("/bad1")
async def read_item(cmd: str):
stdin, stdout, stderr = paramiko_ssh_client.exec_command(cmd)
stdin, stdout, stderr = paramiko_ssh_client.exec_command(cmd) # $ result=BAD
return {"success": stdout}
@app.get("/bad2")
async def read_item(cmd: str):
stdin, stdout, stderr = paramiko_ssh_client.exec_command(command=cmd)
stdin, stdout, stderr = paramiko_ssh_client.exec_command(command=cmd) # $ result=BAD
return {"success": "OK"}
@app.get("/bad3")
async def read_item(cmd: str):
stdin, stdout, stderr = paramiko_ssh_client.connect('hostname', username='user',password='yourpassword',sock=paramiko.ProxyCommand(cmd))
stdin, stdout, stderr = paramiko_ssh_client.connect('hostname', username='user',password='yourpassword',sock=paramiko.ProxyCommand(cmd)) # $ result=BAD
return {"success": "OK"}

1
python/ql/test/experimental/query-tests/Security/CWE-074-paramiko/paramiko.qlref
View File

@@ -1 +0,0 @@
experimental/Security/CWE-074/paramiko/paramiko.ql