hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Remove parameter from predicate for some tiny performance benefits

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2020-01-23 13:29:48 +01:00
parent 77531294bf
commit 5fd1c6fedb
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowDispatch.qll
View File

@@ -98,7 +98,7 @@ private module VirtualDispatch {
.getObjectAddress()
.(VariableAddressInstruction)
.getASTVariable() and
this.flowsFromGlobalUnionField(var, _, a)
this.flowsFromGlobalUnionField(var, a)
)
) and
allowFromArg = true
@@ -112,11 +112,10 @@ private module VirtualDispatch {
)
}
private predicate flowsFromGlobalUnionField(Variable var, Field f, FieldAccess a) {
f.getDeclaringType() instanceof Union and
private predicate flowsFromGlobalUnionField(Variable var, FieldAccess a) {
a.getTarget().getDeclaringType() instanceof Union and
exists(LoadInstruction load |
this.flowsFrom(DataFlow::instructionNode(load), _) and
a.getTarget() = f and
load
.getSourceAddress()
.(FieldAddressInstruction)