hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Fix bad join order in returnNodeAsOutput.

Browse Source
This commit is contained in:
Michael Nebel
2022-03-16 13:44:11 +01:00
parent f6681f30c6
commit 5f7b5ec5df
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
csharp/ql/src/utils/model-generator/ModelGeneratorUtilsSpecific.qll
View File

@@ -86,6 +86,11 @@ string parameterNodeAsInput(DataFlow::ParameterNode p) {
result = "Argument[Qualifier]" and p instanceof InstanceParameterNode
}
pragma[nomagic]
private Parameter getParameter(ReturnNodeExt node, ParameterPosition pos) {
result = node.getEnclosingCallable().getParameter(pos.getPosition())
}
/**
* Gets the model string represention of the the return node `node`.
*/
@@ -94,7 +99,7 @@ string returnNodeAsOutput(ReturnNodeExt node) {
then result = "ReturnValue"
else
exists(ParameterPosition pos | pos = node.getKind().(ParamUpdateReturnKind).getPosition() |
result = parameterAccess(node.getEnclosingCallable().getParameter(pos.getPosition()))
result = parameterAccess(getParameter(node, pos))
or
pos.isThisParameter() and
result = "Argument[Qualifier]"