hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-03-17 04:56:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13152 from github/max-schaefer/unsafe-shell-command-construction-examples-sync

Browse Source 
JavaScript: Use synchronous APIs in examples for js/shell-command-constructed-from-input.
This commit is contained in:
Max Schaefer
2023-05-12 16:50:25 +01:00
committed by GitHub
parent ed0524d08c 2e7eb50319
commit 5dfe52afd0
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/src/Security/CWE-078/examples/unsafe-shell-command-construction.js
View File

@@ -1,5 +1,5 @@
var cp = require("child_process");
module.exports = function download(path, callback) {
cp.exec("wget " + path, callback);
cp.execSync("wget " + path, callback);
}

2
javascript/ql/src/Security/CWE-078/examples/unsafe-shell-command-construction_fixed.js
View File

@@ -1,5 +1,5 @@
var cp = require("child_process");
module.exports = function download(path, callback) {
cp.execFile("wget", [path], callback);
cp.execFileSync("wget", [path], callback);
}