From 46332d4849723561a4a55dd2bccfd72223eeb763 Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Thu, 30 Apr 2020 12:24:38 +0100
Subject: [PATCH 1/9] C++: Eliminate recursion from toString().

---
 cpp/ql/src/semmle/code/cpp/Namespace.qll    | 15 ++++---
 cpp/ql/src/semmle/code/cpp/Variable.qll     | 43 +++++++++++++--------
 cpp/ql/src/semmle/code/cpp/XML.qll          |  4 +-
 cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll |  2 +-
 4 files changed, 39 insertions(+), 25 deletions(-)

diff --git a/cpp/ql/src/semmle/code/cpp/Namespace.qll b/cpp/ql/src/semmle/code/cpp/Namespace.qll
index d53fda87c2f..fe112d70177 100644
--- a/cpp/ql/src/semmle/code/cpp/Namespace.qll
+++ b/cpp/ql/src/semmle/code/cpp/Namespace.qll
@@ -79,7 +79,10 @@ class Namespace extends NameQualifyingElement, @namespace {
   /** Gets the metric namespace. */
   MetricNamespace getMetrics() { result = this }
 
-  override string toString() { result = this.getQualifiedName() }
+  /** Gets a version of the `QualifiedName` that is more suitable for display purposes. */
+  string getFriendlyName() { result = this.getQualifiedName() }
+
+  final override string toString() { result = getFriendlyName() }
 
   /** Gets a declaration of (part of) this namespace. */
   NamespaceDeclarationEntry getADeclarationEntry() { result.getNamespace() = this }
@@ -104,7 +107,7 @@ class NamespaceDeclarationEntry extends Locatable, @namespace_decl {
     namespace_decls(underlyingElement(this), unresolveElement(result), _, _)
   }
 
-  override string toString() { result = this.getNamespace().toString() }
+  override string toString() { result = this.getNamespace().getFriendlyName() }
 
   /**
    * Gets the location of the token preceding the namespace declaration
@@ -150,7 +153,7 @@ class UsingDeclarationEntry extends UsingEntry {
    */
   Declaration getDeclaration() { usings(underlyingElement(this), unresolveElement(result), _) }
 
-  override string toString() { result = "using " + this.getDeclaration().toString() }
+  override string toString() { result = "using declaration" }
 }
 
 /**
@@ -169,7 +172,9 @@ class UsingDirectiveEntry extends UsingEntry {
    */
   Namespace getNamespace() { usings(underlyingElement(this), unresolveElement(result), _) }
 
-  override string toString() { result = "using namespace " + this.getNamespace().toString() }
+  override string toString() {
+    result = "using namespace " + this.getNamespace().getFriendlyName()
+  }
 }
 
 /**
@@ -204,7 +209,7 @@ class GlobalNamespace extends Namespace {
    */
   deprecated string getFullName() { result = this.getName() }
 
-  override string toString() { result = "(global namespace)" }
+  override string getFriendlyName() { result = "(global namespace)" }
 }
 
 /**
diff --git a/cpp/ql/src/semmle/code/cpp/Variable.qll b/cpp/ql/src/semmle/code/cpp/Variable.qll
index 4d546a736dc..3fe58cf6ee7 100644
--- a/cpp/ql/src/semmle/code/cpp/Variable.qll
+++ b/cpp/ql/src/semmle/code/cpp/Variable.qll
@@ -260,24 +260,33 @@ class ParameterDeclarationEntry extends VariableDeclarationEntry {
    */
   int getIndex() { param_decl_bind(underlyingElement(this), result, _) }
 
+  string getAnonymousParameterDescription() {
+    not exists(getName()) and
+    exists(string idx |
+      idx =
+        ((getIndex() + 1).toString() + "th")
+            .replaceAll("1th", "1st")
+            .replaceAll("2th", "2nd")
+            .replaceAll("3th", "3rd")
+            .replaceAll("11st", "11th")
+            .replaceAll("12nd", "12th")
+            .replaceAll("13rd", "13th") and
+      if exists(getCanonicalName())
+      then result = "declaration of " + getCanonicalName() + " as anonymous " + idx + " parameter"
+      else result = "declaration of " + idx + " parameter"
+    )
+  }
+
   override string toString() {
-    if exists(getName())
-    then result = super.toString()
-    else
-      exists(string idx |
-        idx =
-          ((getIndex() + 1).toString() + "th")
-              .replaceAll("1th", "1st")
-              .replaceAll("2th", "2nd")
-              .replaceAll("3th", "3rd")
-              .replaceAll("11st", "11th")
-              .replaceAll("12nd", "12th")
-              .replaceAll("13rd", "13th")
-      |
-        if exists(getCanonicalName())
-        then result = "declaration of " + getCanonicalName() + " as anonymous " + idx + " parameter"
-        else result = "declaration of " + idx + " parameter"
-      )
+    isDefinition() and
+    result = "definition of " + getName()
+    or
+    not isDefinition() and
+    if getName() = getCanonicalName()
+    then result = "declaration of " + getName()
+    else result = "declaration of " + getCanonicalName() + " as " + getName()
+    or
+    result = getAnonymousParameterDescription()
   }
 
   /**
diff --git a/cpp/ql/src/semmle/code/cpp/XML.qll b/cpp/ql/src/semmle/code/cpp/XML.qll
index dc7836aaabe..713903b63e6 100755
--- a/cpp/ql/src/semmle/code/cpp/XML.qll
+++ b/cpp/ql/src/semmle/code/cpp/XML.qll
@@ -116,7 +116,7 @@ class XMLFile extends XMLParent, File {
   XMLFile() { xmlEncoding(this, _) }
 
   /** Gets a printable representation of this XML file. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 
   /** Gets the name of this XML file. */
   override string getName() { result = File.super.getAbsolutePath() }
@@ -236,7 +236,7 @@ class XMLElement extends @xmlelement, XMLParent, XMLLocatable {
   string getAttributeValue(string name) { result = this.getAttribute(name).getValue() }
 
   /** Gets a printable representation of this XML element. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 }
 
 /**
diff --git a/cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll b/cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll
index f634d9239b3..35d0ccb75a0 100644
--- a/cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll
+++ b/cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll
@@ -99,7 +99,7 @@ class Closure extends Class {
  * ```
  */
 class LambdaCapture extends Locatable, @lambdacapture {
-  override string toString() { result = getField().toString() }
+  override string toString() { result = getField().getName() }
 
   override string getCanonicalQLClass() { result = "LambdaCapture" }
 

From 9fc37d174e7b3d35ad9b56685a76627686d7afd5 Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Mon, 4 May 2020 17:33:52 +0100
Subject: [PATCH 2/9] C++: Update the 'usings' tests.

---
 cpp/ql/test/library-tests/usings/Usings1.expected | 12 ++++++------
 cpp/ql/test/library-tests/usings/Usings2.expected | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/cpp/ql/test/library-tests/usings/Usings1.expected b/cpp/ql/test/library-tests/usings/Usings1.expected
index 29fc4ebd652..60f6880ee20 100644
--- a/cpp/ql/test/library-tests/usings/Usings1.expected
+++ b/cpp/ql/test/library-tests/usings/Usings1.expected
@@ -1,7 +1,7 @@
-| templates.cpp:9:5:9:14 | using c |
-| usings.cpp:8:1:8:11 | using nf |
+| templates.cpp:9:5:9:14 | using declaration |
+| usings.cpp:8:1:8:11 | using declaration |
 | usings.cpp:9:1:9:17 | using namespace N |
-| usings.cpp:18:3:18:13 | using bf |
-| usings.cpp:21:5:21:14 | using gf |
-| usings.cpp:34:3:34:20 | using tbf |
-| usings.cpp:42:5:42:22 | using foo |
+| usings.cpp:18:3:18:13 | using declaration |
+| usings.cpp:21:5:21:14 | using declaration |
+| usings.cpp:34:3:34:20 | using declaration |
+| usings.cpp:42:5:42:22 | using declaration |
diff --git a/cpp/ql/test/library-tests/usings/Usings2.expected b/cpp/ql/test/library-tests/usings/Usings2.expected
index bb23b50e41a..d8e0efbe299 100644
--- a/cpp/ql/test/library-tests/usings/Usings2.expected
+++ b/cpp/ql/test/library-tests/usings/Usings2.expected
@@ -1,7 +1,7 @@
-| templates.cpp:9:5:9:14 | using c | file://:0:0:0:0 | std |
-| usings.cpp:8:1:8:11 | using nf | file://:0:0:0:0 | (global namespace) |
+| templates.cpp:9:5:9:14 | using declaration | file://:0:0:0:0 | std |
+| usings.cpp:8:1:8:11 | using declaration | file://:0:0:0:0 | (global namespace) |
 | usings.cpp:9:1:9:17 | using namespace N | file://:0:0:0:0 | (global namespace) |
-| usings.cpp:18:3:18:13 | using bf | usings.cpp:16:8:16:8 | D |
-| usings.cpp:21:5:21:14 | using gf | usings.cpp:20:13:23:3 | { ... } |
-| usings.cpp:34:3:34:20 | using tbf | usings.cpp:32:8:32:9 | TD |
-| usings.cpp:42:5:42:22 | using foo | usings.cpp:41:11:41:15 | nsbar |
+| usings.cpp:18:3:18:13 | using declaration | usings.cpp:16:8:16:8 | D |
+| usings.cpp:21:5:21:14 | using declaration | usings.cpp:20:13:23:3 | { ... } |
+| usings.cpp:34:3:34:20 | using declaration | usings.cpp:32:8:32:9 | TD |
+| usings.cpp:42:5:42:22 | using declaration | usings.cpp:41:11:41:15 | nsbar |

From 3d431607e7fe70834234cd7d6f858a36f635b9db Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Mon, 4 May 2020 17:24:04 +0100
Subject: [PATCH 3/9] C++: Combine the usings tests and add detail about
 classes.

---
 cpp/ql/test/library-tests/usings/Usings1.expected | 14 +++++++-------
 cpp/ql/test/library-tests/usings/Usings1.ql       | 12 +++++++++++-
 cpp/ql/test/library-tests/usings/Usings2.expected |  7 -------
 cpp/ql/test/library-tests/usings/Usings2.ql       |  5 -----
 4 files changed, 18 insertions(+), 20 deletions(-)
 delete mode 100644 cpp/ql/test/library-tests/usings/Usings2.expected
 delete mode 100644 cpp/ql/test/library-tests/usings/Usings2.ql

diff --git a/cpp/ql/test/library-tests/usings/Usings1.expected b/cpp/ql/test/library-tests/usings/Usings1.expected
index 60f6880ee20..9add0766111 100644
--- a/cpp/ql/test/library-tests/usings/Usings1.expected
+++ b/cpp/ql/test/library-tests/usings/Usings1.expected
@@ -1,7 +1,7 @@
-| templates.cpp:9:5:9:14 | using declaration |
-| usings.cpp:8:1:8:11 | using declaration |
-| usings.cpp:9:1:9:17 | using namespace N |
-| usings.cpp:18:3:18:13 | using declaration |
-| usings.cpp:21:5:21:14 | using declaration |
-| usings.cpp:34:3:34:20 | using declaration |
-| usings.cpp:42:5:42:22 | using declaration |
+| templates.cpp:9:5:9:14 | using declaration | UsingDeclarationEntry, enclosingElement:std |
+| usings.cpp:8:1:8:11 | using declaration | UsingDeclarationEntry, enclosingElement:(global namespace) |
+| usings.cpp:9:1:9:17 | using namespace N | UsingDirectiveEntry, enclosingElement:(global namespace) |
+| usings.cpp:18:3:18:13 | using declaration | UsingDeclarationEntry, enclosingElement:D |
+| usings.cpp:21:5:21:14 | using declaration | UsingDeclarationEntry, enclosingElement:{ ... } |
+| usings.cpp:34:3:34:20 | using declaration | UsingDeclarationEntry, enclosingElement:TD |
+| usings.cpp:42:5:42:22 | using declaration | UsingDeclarationEntry, enclosingElement:nsbar |
diff --git a/cpp/ql/test/library-tests/usings/Usings1.ql b/cpp/ql/test/library-tests/usings/Usings1.ql
index 5e374a82059..2011c196571 100644
--- a/cpp/ql/test/library-tests/usings/Usings1.ql
+++ b/cpp/ql/test/library-tests/usings/Usings1.ql
@@ -1,4 +1,14 @@
 import cpp
 
+string describe(UsingEntry ue) {
+  ue instanceof UsingDeclarationEntry and
+  result = "UsingDeclarationEntry"
+  or
+  ue instanceof UsingDirectiveEntry and
+  result = "UsingDirectiveEntry"
+  or
+  result = "enclosingElement:" + ue.getEnclosingElement().toString()
+}
+
 from UsingEntry ue
-select ue
+select ue, concat(describe(ue), ", ")
diff --git a/cpp/ql/test/library-tests/usings/Usings2.expected b/cpp/ql/test/library-tests/usings/Usings2.expected
deleted file mode 100644
index d8e0efbe299..00000000000
--- a/cpp/ql/test/library-tests/usings/Usings2.expected
+++ /dev/null
@@ -1,7 +0,0 @@
-| templates.cpp:9:5:9:14 | using declaration | file://:0:0:0:0 | std |
-| usings.cpp:8:1:8:11 | using declaration | file://:0:0:0:0 | (global namespace) |
-| usings.cpp:9:1:9:17 | using namespace N | file://:0:0:0:0 | (global namespace) |
-| usings.cpp:18:3:18:13 | using declaration | usings.cpp:16:8:16:8 | D |
-| usings.cpp:21:5:21:14 | using declaration | usings.cpp:20:13:23:3 | { ... } |
-| usings.cpp:34:3:34:20 | using declaration | usings.cpp:32:8:32:9 | TD |
-| usings.cpp:42:5:42:22 | using declaration | usings.cpp:41:11:41:15 | nsbar |
diff --git a/cpp/ql/test/library-tests/usings/Usings2.ql b/cpp/ql/test/library-tests/usings/Usings2.ql
deleted file mode 100644
index bc4a076b0c5..00000000000
--- a/cpp/ql/test/library-tests/usings/Usings2.ql
+++ /dev/null
@@ -1,5 +0,0 @@
-import cpp
-
-from UsingEntry ue, Element e
-where e = ue.getEnclosingElement()
-select ue, e

From 511d7c91997958f08d56f4422b69b306d5efc1bc Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Mon, 4 May 2020 15:07:32 +0100
Subject: [PATCH 4/9] C++: Improve solution for UsingDeclarationEntry.

---
 cpp/ql/src/semmle/code/cpp/Declaration.qll        |  7 ++++++-
 cpp/ql/src/semmle/code/cpp/Namespace.qll          |  2 +-
 cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll       |  2 +-
 cpp/ql/test/library-tests/usings/Usings1.expected | 12 ++++++------
 4 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/cpp/ql/src/semmle/code/cpp/Declaration.qll b/cpp/ql/src/semmle/code/cpp/Declaration.qll
index 840705b01b5..a4a4a4af2e6 100644
--- a/cpp/ql/src/semmle/code/cpp/Declaration.qll
+++ b/cpp/ql/src/semmle/code/cpp/Declaration.qll
@@ -98,7 +98,12 @@ class Declaration extends Locatable, @declaration {
     this.hasQualifiedName(namespaceQualifier, "", baseName)
   }
 
-  override string toString() { result = this.getName() }
+  /**
+   * Gets a description of this `Declaration` for display purposes.
+   */
+  string getDescription() { result = this.getName() }
+
+  final override string toString() { result = this.getDescription() }
 
   /**
    * Gets the name of this declaration.
diff --git a/cpp/ql/src/semmle/code/cpp/Namespace.qll b/cpp/ql/src/semmle/code/cpp/Namespace.qll
index fe112d70177..da6b1559cfa 100644
--- a/cpp/ql/src/semmle/code/cpp/Namespace.qll
+++ b/cpp/ql/src/semmle/code/cpp/Namespace.qll
@@ -153,7 +153,7 @@ class UsingDeclarationEntry extends UsingEntry {
    */
   Declaration getDeclaration() { usings(underlyingElement(this), unresolveElement(result), _) }
 
-  override string toString() { result = "using declaration" }
+  override string toString() { result = "using " + this.getDeclaration().getDescription() }
 }
 
 /**
diff --git a/cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll b/cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll
index 35d0ccb75a0..4a5b1b21c8d 100644
--- a/cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll
+++ b/cpp/ql/src/semmle/code/cpp/exprs/Lambda.qll
@@ -86,7 +86,7 @@ class Closure extends Class {
     result.getName() = "operator()"
   }
 
-  override string toString() { result = "decltype([...](...){...})" }
+  override string getDescription() { result = "decltype([...](...){...})" }
 }
 
 /**
diff --git a/cpp/ql/test/library-tests/usings/Usings1.expected b/cpp/ql/test/library-tests/usings/Usings1.expected
index 9add0766111..c29cf7dd11f 100644
--- a/cpp/ql/test/library-tests/usings/Usings1.expected
+++ b/cpp/ql/test/library-tests/usings/Usings1.expected
@@ -1,7 +1,7 @@
-| templates.cpp:9:5:9:14 | using declaration | UsingDeclarationEntry, enclosingElement:std |
-| usings.cpp:8:1:8:11 | using declaration | UsingDeclarationEntry, enclosingElement:(global namespace) |
+| templates.cpp:9:5:9:14 | using c | UsingDeclarationEntry, enclosingElement:std |
+| usings.cpp:8:1:8:11 | using nf | UsingDeclarationEntry, enclosingElement:(global namespace) |
 | usings.cpp:9:1:9:17 | using namespace N | UsingDirectiveEntry, enclosingElement:(global namespace) |
-| usings.cpp:18:3:18:13 | using declaration | UsingDeclarationEntry, enclosingElement:D |
-| usings.cpp:21:5:21:14 | using declaration | UsingDeclarationEntry, enclosingElement:{ ... } |
-| usings.cpp:34:3:34:20 | using declaration | UsingDeclarationEntry, enclosingElement:TD |
-| usings.cpp:42:5:42:22 | using declaration | UsingDeclarationEntry, enclosingElement:nsbar |
+| usings.cpp:18:3:18:13 | using bf | UsingDeclarationEntry, enclosingElement:D |
+| usings.cpp:21:5:21:14 | using gf | UsingDeclarationEntry, enclosingElement:{ ... } |
+| usings.cpp:34:3:34:20 | using tbf | UsingDeclarationEntry, enclosingElement:TD |
+| usings.cpp:42:5:42:22 | using foo | UsingDeclarationEntry, enclosingElement:nsbar |

From a70f5344580516ed9b71b6266c44567b4a9d1d34 Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Tue, 5 May 2020 09:17:39 +0100
Subject: [PATCH 5/9] Sync identical files.

---
 csharp/ql/src/semmle/code/csharp/XML.qll    | 4 ++--
 java/ql/src/semmle/code/xml/XML.qll         | 4 ++--
 javascript/ql/src/semmle/javascript/XML.qll | 4 ++--
 python/ql/src/semmle/python/xml/XML.qll     | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/csharp/ql/src/semmle/code/csharp/XML.qll b/csharp/ql/src/semmle/code/csharp/XML.qll
index dc7836aaabe..713903b63e6 100755
--- a/csharp/ql/src/semmle/code/csharp/XML.qll
+++ b/csharp/ql/src/semmle/code/csharp/XML.qll
@@ -116,7 +116,7 @@ class XMLFile extends XMLParent, File {
   XMLFile() { xmlEncoding(this, _) }
 
   /** Gets a printable representation of this XML file. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 
   /** Gets the name of this XML file. */
   override string getName() { result = File.super.getAbsolutePath() }
@@ -236,7 +236,7 @@ class XMLElement extends @xmlelement, XMLParent, XMLLocatable {
   string getAttributeValue(string name) { result = this.getAttribute(name).getValue() }
 
   /** Gets a printable representation of this XML element. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 }
 
 /**
diff --git a/java/ql/src/semmle/code/xml/XML.qll b/java/ql/src/semmle/code/xml/XML.qll
index dc7836aaabe..713903b63e6 100755
--- a/java/ql/src/semmle/code/xml/XML.qll
+++ b/java/ql/src/semmle/code/xml/XML.qll
@@ -116,7 +116,7 @@ class XMLFile extends XMLParent, File {
   XMLFile() { xmlEncoding(this, _) }
 
   /** Gets a printable representation of this XML file. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 
   /** Gets the name of this XML file. */
   override string getName() { result = File.super.getAbsolutePath() }
@@ -236,7 +236,7 @@ class XMLElement extends @xmlelement, XMLParent, XMLLocatable {
   string getAttributeValue(string name) { result = this.getAttribute(name).getValue() }
 
   /** Gets a printable representation of this XML element. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 }
 
 /**
diff --git a/javascript/ql/src/semmle/javascript/XML.qll b/javascript/ql/src/semmle/javascript/XML.qll
index dc7836aaabe..713903b63e6 100755
--- a/javascript/ql/src/semmle/javascript/XML.qll
+++ b/javascript/ql/src/semmle/javascript/XML.qll
@@ -116,7 +116,7 @@ class XMLFile extends XMLParent, File {
   XMLFile() { xmlEncoding(this, _) }
 
   /** Gets a printable representation of this XML file. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 
   /** Gets the name of this XML file. */
   override string getName() { result = File.super.getAbsolutePath() }
@@ -236,7 +236,7 @@ class XMLElement extends @xmlelement, XMLParent, XMLLocatable {
   string getAttributeValue(string name) { result = this.getAttribute(name).getValue() }
 
   /** Gets a printable representation of this XML element. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 }
 
 /**
diff --git a/python/ql/src/semmle/python/xml/XML.qll b/python/ql/src/semmle/python/xml/XML.qll
index dc7836aaabe..713903b63e6 100755
--- a/python/ql/src/semmle/python/xml/XML.qll
+++ b/python/ql/src/semmle/python/xml/XML.qll
@@ -116,7 +116,7 @@ class XMLFile extends XMLParent, File {
   XMLFile() { xmlEncoding(this, _) }
 
   /** Gets a printable representation of this XML file. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 
   /** Gets the name of this XML file. */
   override string getName() { result = File.super.getAbsolutePath() }
@@ -236,7 +236,7 @@ class XMLElement extends @xmlelement, XMLParent, XMLLocatable {
   string getAttributeValue(string name) { result = this.getAttribute(name).getValue() }
 
   /** Gets a printable representation of this XML element. */
-  override string toString() { result = XMLParent.super.toString() }
+  override string toString() { result = getName() }
 }
 
 /**

From 31a7e2c34e8c3799a6d0c5aeaba01943fcea9db3 Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Tue, 5 May 2020 10:05:18 +0100
Subject: [PATCH 6/9] C++: Make getAnonymousParameterDescription private.

---
 cpp/ql/src/semmle/code/cpp/Variable.qll | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cpp/ql/src/semmle/code/cpp/Variable.qll b/cpp/ql/src/semmle/code/cpp/Variable.qll
index 3fe58cf6ee7..54f39ab2bb6 100644
--- a/cpp/ql/src/semmle/code/cpp/Variable.qll
+++ b/cpp/ql/src/semmle/code/cpp/Variable.qll
@@ -260,7 +260,7 @@ class ParameterDeclarationEntry extends VariableDeclarationEntry {
    */
   int getIndex() { param_decl_bind(underlyingElement(this), result, _) }
 
-  string getAnonymousParameterDescription() {
+  private string getAnonymousParameterDescription() {
     not exists(getName()) and
     exists(string idx |
       idx =

From 0b381b9ba72122e260443e0899b46439375ed464 Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Tue, 5 May 2020 12:58:54 +0100
Subject: [PATCH 7/9] C++: Autoformat.

---
 cpp/ql/src/semmle/code/cpp/Namespace.qll | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/cpp/ql/src/semmle/code/cpp/Namespace.qll b/cpp/ql/src/semmle/code/cpp/Namespace.qll
index da6b1559cfa..37cc9f98958 100644
--- a/cpp/ql/src/semmle/code/cpp/Namespace.qll
+++ b/cpp/ql/src/semmle/code/cpp/Namespace.qll
@@ -172,9 +172,7 @@ class UsingDirectiveEntry extends UsingEntry {
    */
   Namespace getNamespace() { usings(underlyingElement(this), unresolveElement(result), _) }
 
-  override string toString() {
-    result = "using namespace " + this.getNamespace().getFriendlyName()
-  }
+  override string toString() { result = "using namespace " + this.getNamespace().getFriendlyName() }
 }
 
 /**

From 2940f4794e77a7d4c640b5437b0ff5c0a2304774 Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Tue, 5 May 2020 13:06:48 +0100
Subject: [PATCH 8/9] C++: Fix isfromtemplateinstantiation test.

---
 .../isfromtemplateinstantiation.ql                            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.ql b/cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.ql
index 3a34cc2ca1b..dd97fdfc967 100644
--- a/cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.ql
+++ b/cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.ql
@@ -2,7 +2,7 @@ import cpp
 
 class FunctionMonkeyPatch extends Function {
   language[monotonicAggregates]
-  override string toString() {
+  override string getDescription() {
     exists(string name, string templateArgs, string args |
       result = name + templateArgs + args and
       name = this.getQualifiedName() and
@@ -30,7 +30,7 @@ class FunctionMonkeyPatch extends Function {
 }
 
 class ParameterMonkeyPatch extends Parameter {
-  override string toString() { result = super.getType().getName() + " " + super.toString() }
+  override string getDescription() { result = super.getType().getName() + " " + super.getDescription() }
 }
 
 from Element e, Element ti

From 3e2e69c06a0fef1b3af865ddf71c95db668ad686 Mon Sep 17 00:00:00 2001
From: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
Date: Tue, 5 May 2020 16:55:15 +0100
Subject: [PATCH 9/9] C++: Autoformat.

---
 .../isfromtemplateinstantiation.ql                            | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.ql b/cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.ql
index dd97fdfc967..454f901fe38 100644
--- a/cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.ql
+++ b/cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.ql
@@ -30,7 +30,9 @@ class FunctionMonkeyPatch extends Function {
 }
 
 class ParameterMonkeyPatch extends Parameter {
-  override string getDescription() { result = super.getType().getName() + " " + super.getDescription() }
+  override string getDescription() {
+    result = super.getType().getName() + " " + super.getDescription()
+  }
 }
 
 from Element e, Element ti