mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
Remove non-breaking spaces from code
This commit is contained in:
@@ -1,2 +1,2 @@
|
||||
lgtm,codescanning
|
||||
* The extractor now only extracts go.mod files belonging to extracted packages. In particular, vendored go.mod files will no longer be extracted unless the vendored package is explicitly passed to the extractor. This will remove unexpected `GoModExpr` and similar expressions seen by queries.
|
||||
* The extractor now only extracts go.mod files belonging to extracted packages. In particular, vendored go.mod files will no longer be extracted unless the vendored package is explicitly passed to the extractor. This will remove unexpected `GoModExpr` and similar expressions seen by queries.
|
||||
|
||||
@@ -28,7 +28,7 @@ class Architecture extends string {
|
||||
}
|
||||
|
||||
/**
|
||||
* Gets the integer and pointer type width for this architecture.
|
||||
* Gets the integer and pointer type width for this architecture.
|
||||
*
|
||||
* As of the time of writing, this appears to always be identical -- there aren't
|
||||
* Go architectures with 64-bit pointers but 32-bit ints, for example.
|
||||
|
||||
@@ -994,7 +994,7 @@ module Public {
|
||||
class ComponentReadNode extends ReadNode {
|
||||
override IR::ComponentReadInstruction insn;
|
||||
|
||||
/** Gets the data-flow node representing the base from which the field or element is read. */
|
||||
/** Gets the data-flow node representing the base from which the field or element is read. */
|
||||
Node getBase() { result = DataFlow::instructionNode(insn.getBase()) }
|
||||
}
|
||||
|
||||
|
||||
@@ -109,7 +109,7 @@ module Beego {
|
||||
|
||||
override string getAContentType() {
|
||||
// Super-method provides content-types for `Body`, which requires us to search
|
||||
// for `ContentType` and `Header` calls against the same `BeegoOutput` instance
|
||||
// for `ContentType` and `Header` calls against the same `BeegoOutput` instance
|
||||
result = super.getAContentType()
|
||||
or
|
||||
// Specifically describe methods that set the content-type and body in one operation:
|
||||
|
||||
@@ -22,7 +22,7 @@ the returned pointer.</p>
|
||||
|
||||
<sample src="MissingErrorCheck.go" />
|
||||
|
||||
<p>The corrected version of <code>user</code> checks <code>err</code> before using <code>ptr</code>.</p>
|
||||
<p>The corrected version of <code>user</code> checks <code>err</code> before using <code>ptr</code>.</p>
|
||||
|
||||
<sample src="MissingErrorCheckGood.go" />
|
||||
|
||||
|
||||
@@ -22,7 +22,7 @@ predicate isNil(DataFlow::Node node) { node = Builtin::nil().getARead() }
|
||||
/**
|
||||
* Matches if `call` may return a nil pointer alongside an error value.
|
||||
*
|
||||
* This is both an over- and under-estimate: over in that we assume opaque functions may use this
|
||||
* This is both an over- and under-estimate: over in that we assume opaque functions may use this
|
||||
* convention, and under in that functions with bodies are only recognized if they use a literal
|
||||
* `nil` for the pointer return value at some return site.
|
||||
*/
|
||||
|
||||
@@ -211,7 +211,7 @@ module TlsInsecureCipherSuitesFlow = TaintTracking::Global<TlsInsecureCipherSuit
|
||||
|
||||
/**
|
||||
* Holds if an insecure TLS cipher suite flows from `source` to `sink`, where `sink`
|
||||
* is written to the CipherSuites list of a `tls.Config` instance. `message` describes
|
||||
* is written to the CipherSuites list of a `tls.Config` instance. `message` describes
|
||||
* the exact problem found.
|
||||
*/
|
||||
predicate isInsecureTlsCipherFlow(
|
||||
|
||||
@@ -297,7 +297,7 @@ func testUtilsPropagators(c *beego.Controller) {
|
||||
c.CustomAbort(500, utils.SlicePad(untainted, 10, genericFiles[0])[0].(*multipart.FileHeader).Filename)
|
||||
c.CustomAbort(500, utils.SlicePad(genericFiles, 10, untainted[0])[0].(*multipart.FileHeader).Filename)
|
||||
c.CustomAbort(500, utils.SliceRand(genericFiles).(*multipart.FileHeader).Filename)
|
||||
// Note this is misnamed -- it's a map operation, not a reduce
|
||||
// Note this is misnamed -- it's a map operation, not a reduce
|
||||
c.CustomAbort(500, utils.SliceReduce(genericFiles, func(x interface{}) interface{} { return x })[0].(*multipart.FileHeader).Filename)
|
||||
c.CustomAbort(500, utils.SliceShuffle(genericFiles)[0].(*multipart.FileHeader).Filename)
|
||||
c.CustomAbort(500, utils.SliceUnique(genericFiles)[0].(*multipart.FileHeader).Filename)
|
||||
|
||||
@@ -26,19 +26,19 @@ type MyRoute struct {
|
||||
// Implement some request handlers on that Controller exhibiting some common problems:
|
||||
|
||||
func (c MyRoute) Handler1() revel.Result {
|
||||
// GOOD: the Render function is likely to properly escape the user-controlled parameter.
|
||||
// GOOD: the Render function is likely to properly escape the user-controlled parameter.
|
||||
return c.Render("someviewparam", c.Params.Form.Get("someField"))
|
||||
}
|
||||
|
||||
func (c MyRoute) Handler2() revel.Result {
|
||||
// BAD: the RenderBinary function copies an `io.Reader` to the user's browser.
|
||||
// BAD: the RenderBinary function copies an `io.Reader` to the user's browser.
|
||||
buf := &bytes.Buffer{}
|
||||
buf.WriteString(c.Params.Form.Get("someField"))
|
||||
return c.RenderBinary(buf, "index.html", revel.Inline, time.Now()) // $ responsebody='buf'
|
||||
}
|
||||
|
||||
func (c MyRoute) Handler3() revel.Result {
|
||||
// GOOD: the RenderBinary function copies an `io.Reader` to the user's browser, but the filename
|
||||
// GOOD: the RenderBinary function copies an `io.Reader` to the user's browser, but the filename
|
||||
// means it will be given a safe content-type.
|
||||
buf := &bytes.Buffer{}
|
||||
buf.WriteString(c.Params.Form.Get("someField"))
|
||||
|
||||
Reference in New Issue
Block a user