hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Cover more cases of returning *this

Browse Source
This commit is contained in:
Jonas Jensen
2018-10-25 09:52:57 +02:00
parent d144f0d154
commit 5cbfdd1029
3 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/test/query-tests/jsf/4.10 Classes/AV Rule 82/AV Rule 82.cpp
View File

@@ -134,7 +134,7 @@ public:
};
class Reachability {
Reachability &operator=(Reachability &that) { // GOOD [FALSE POSITIVE]
Reachability &operator=(Reachability &that) { // GOOD
int one = 1;
if (one)
return *this;
@@ -160,11 +160,11 @@ class Reachability {
return &staticInstance; // unreachable
}
Reachability &operator=(int _val) { // GOOD [FALSE POSITIVE]
Reachability &operator=(int _val) { // GOOD
return returnThisReference();
}
Reachability &operator=(short _val) { // GOOD [FALSE POSITIVE]
Reachability &operator=(short _val) { // GOOD
return *returnThisPointer();
}

3
cpp/ql/test/query-tests/jsf/4.10 Classes/AV Rule 82/AV Rule 82.expected
View File

@@ -2,6 +2,3 @@
| AV Rule 82.cpp:24:8:24:16 | operator= | Assignment operator in class Bad2 should have return type Bad2&. Otherwise a copy is created at each call. |
| AV Rule 82.cpp:63:29:63:37 | operator= | Assignment operator in class TemplateReturnAssignment<T> does not return a reference to *this. |
| AV Rule 82.cpp:63:29:63:37 | operator= | Assignment operator in class TemplateReturnAssignment<int> does not return a reference to *this. |
| AV Rule 82.cpp:137:17:137:25 | operator= | Assignment operator in class Reachability does not return a reference to *this. |
| AV Rule 82.cpp:163:17:163:25 | operator= | Assignment operator in class Reachability does not return a reference to *this. |
| AV Rule 82.cpp:167:17:167:25 | operator= | Assignment operator in class Reachability does not return a reference to *this. |