hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8351 from erik-krogh/inconsistentDep

Browse Source 
QL: add query detecting inconsistent deprecations
This commit is contained in:
Erik Krogh Kristensen
2022-07-12 23:12:24 +02:00
committed by GitHub
parent e092cb02cd 8c6022b78a
commit 5cbe01d8dc
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
ql/ql/src/queries/bugs/InconsistentDeprecation.ql Normal file
View File

@@ -0,0 +1,24 @@
/**
* @name Inconsistent deprecation
* @description A deprecated predicate that overrides a non-deprecated predicate is an indication that the super-predicate should be deprecated.
* @kind problem
* @problem.severity warning
* @id ql/inconsistent-deprecation
* @tags correctness
* maintanability
* @precision very-high
*/
import ql
predicate overrides(ClassPredicate sub, ClassPredicate sup, string description, string overrides) {
sub.overrides(sup) and description = "predicate" and overrides = "predicate"
}
from AstNode sub, AstNode sup, string description, string overrides
where
overrides(sub, sup, description, overrides) and
sub.hasAnnotation("deprecated") and
not sup.hasAnnotation("deprecated")
select sub, "This deprecated " + description + " overrides $@. Consider deprecating both.", sup,
"a non-deprecated " + overrides