hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Efficiency improvement (force a better join order)

Browse Source
This commit is contained in:
Benjamin Rodes
2024-02-13 09:42:08 -08:00
parent 091416131b
commit 5c508553f3
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
View File

@@ -86,15 +86,14 @@ predicate isNonConst(DataFlow::Node node) {
c = node.asIndirectExpr()
// and not hasConstSpecifier(c.getType())
) and
not exists(Function func, FunctionInput input, FunctionOutput output, CallInstruction call |
not exists(FunctionInput input, FunctionOutput output, CallInstruction call |
// NOTE: we must include dataflow and taintflow. e.g., including only dataflow we will find sprintf
// variant function's output are now possible non-const sources
(
func.(DataFlowFunction).hasDataFlow(input, output) or
func.(TaintFunction).hasTaintFlow(input, output)
pragma[only_bind_out](call.getStaticCallTarget()).(DataFlowFunction).hasDataFlow(input, output) or
pragma[only_bind_out](call.getStaticCallTarget()).(TaintFunction).hasTaintFlow(input, output)
) and
node = callOutput(call, output) and
call.getStaticCallTarget() = func
node = callOutput(call, output)
) and
not exists(Call c |
c.getTarget().hasDefinition() and