Exclude classes with a writeReplace method from serializability checks

This commit is contained in:
Chris Smowton
2025-01-06 14:42:44 +00:00
parent b60c86077d
commit 5c2df36786
4 changed files with 36 additions and 0 deletions

View File

@@ -0,0 +1 @@
| Test.java:12:7:12:7 | A | This class is serializable, but its non-serializable super-class $@ does not declare a no-argument constructor. | Test.java:4:7:4:20 | NonSerialzable | NonSerialzable |

View File

@@ -0,0 +1 @@
Likely Bugs/Serialization/MissingVoidConstructorsOnSerializable.ql

View File

@@ -0,0 +1,24 @@
import java.io.ObjectStreamException;
import java.io.Serializable;
class NonSerialzable {
// Has no default constructor
public NonSerialzable(int x) { }
}
// BAD: Serializable but its parent cannot be instantiated
class A extends NonSerialzable implements Serializable {
public A() { super(1); }
}
// GOOD: writeReplaces itself, so unlikely to be deserialized
// according to default rules.
class B extends NonSerialzable implements Serializable {
public B() { super(2); }
public Object writeReplace() throws ObjectStreamException {
return null;
}
}