From 5bd044211ebcc76c7040ffbaa27be3ffcf3e9b20 Mon Sep 17 00:00:00 2001 From: Jorge <46056498+jorgectf@users.noreply.github.com> Date: Mon, 26 Jun 2023 13:27:23 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Asger F --- .../dataflow/CodeInjectionCustomizations.qll | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll index 5d1a9bc2896..d4e62dba635 100644 --- a/javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll +++ b/javascript/ql/lib/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll @@ -316,7 +316,7 @@ module CodeInjection { * A value interpreted as code by the `webix` library. */ class WebixExec extends Sink { - WebixExec() { this = DataFlow::moduleImport("webix").getAMemberCall("exec").getArgument(0) } + WebixExec() { this = API::moduleImport("webix").getMember("exec").getParameter(0).asSink() } } /** A sink for code injection via template injection. */ @@ -431,15 +431,15 @@ module CodeInjection { */ class WebixTemplateSink extends TemplateSink { WebixTemplateSink() { - this = DataFlow::moduleImport("webix").getAMemberCall("ui").getOptionArgument(0, "template") + this = API::moduleImport("webix").getMember("ui").getParameter(0).getMember("template").asSink() or this.asExpr() = - DataFlow::moduleImport("webix") - .getAMemberCall("ui") - .getOptionArgument(0, "template") - .asExpr() - .(Function) - .getAReturnedExpr() + API::moduleImport("webix") + .getMember("ui") + .getParameter(0) + .getMember("template") + .getReturn() + .asSink() } }