hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix TODO.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2022-12-02 11:25:18 +00:00
parent 68f0997d87
commit 5ae3228928
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll
View File

@@ -292,9 +292,8 @@ predicate outNodeHasAddressAndIndex(
}
private predicate defToNode(Node nodeFrom, Def def) {
// TODO: This is not yet needed (and in fact, the compiler rejects it because `exists(def.getValue().asOperand())` never holds).
// nodeHasOperand(nodeFrom, def.getValue().asOperand(), def.getIndirectionIndex())
// or
nodeHasOperand(nodeFrom, def.getValue().asOperand(), def.getIndirectionIndex())
or
nodeHasInstruction(nodeFrom, def.getValue().asInstruction(), def.getIndirectionIndex())
}