hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: improve alert location of js/angular/duplicate-dependency

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-12-11 14:04:04 +01:00
parent a4b3b1e8c8
commit 5acd1ca26d
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/ql/src/AngularJS/DuplicateDependency.ql
View File

@@ -10,6 +10,7 @@
*/
import javascript
import semmle.javascript.RestrictedLocations
predicate isRepeatedDependency(AngularJS::InjectableFunction f, string name, ASTNode location) {
exists(int i, int j | i < j and
@@ -20,4 +21,4 @@ predicate isRepeatedDependency(AngularJS::InjectableFunction f, string name, AST
from AngularJS::InjectableFunction f, ASTNode node, string name
where isRepeatedDependency(f, name, node) and
not count(f.asFunction().getParameterByName(name)) > 1 // avoid duplicating reports from js/duplicate-parameter-name
select f, "This function has a duplicate dependency '$@'.", node, name
select (FirstLineOf)f.asFunction(), "This function has a duplicate dependency '$@'.", node, name