hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 09:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: add spurious test case for StringBuilder.append

Browse Source
This commit is contained in:
Jami Cogswell
2024-03-13 09:36:42 -04:00
parent 04d27f2d65
commit 5ac453eb38
1 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
java/ql/test/query-tests/security/CWE-552/UrlForwardTest.java
View File

@@ -388,4 +388,25 @@ public class UrlForwardTest extends HttpServlet implements Filter {
sc.getRequestDispatcher(VALID_FORWARD).forward(request, response);
}
}
// Test `StringBuilder.append` sequence with `?` appended before the user input
private static final String LOGIN_URL = "/UI/Login";
public void doPost2(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
StringBuilder forwardUrl = new StringBuilder(200);
forwardUrl.append(LOGIN_URL);
String queryString = request.getQueryString();
// should be sanitized due to the `?` appended
forwardUrl.append('?').append(queryString);
String fUrl = forwardUrl.toString();
ServletConfig config = getServletConfig();
RequestDispatcher dispatcher = config.getServletContext().getRequestDispatcher(fUrl); // $ SPURIOUS: hasUrlForward
dispatcher.forward(request, response);
}
}