hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-23 18:33:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Be more lenient about keywords used as identifiers.

Browse Source
This commit is contained in:
Max Schaefer
2019-01-29 15:57:37 +00:00
parent dbbb961b48
commit 5a89024507
3 changed files with 109 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/extractor/src/com/semmle/jcorn/Parser.java
View File

@@ -2106,8 +2106,10 @@ public class Parser {
if (this.inAsync && this.value.equals("await"))
this.raiseRecoverable(this.start, "Can not use 'await' as identifier inside an async function");
name = String.valueOf(this.value);
} else if (liberal && this.type.keyword != null) {
} else if (this.type.keyword != null) {
name = this.type.keyword;
if (!liberal)
raiseRecoverable(this.start, "Cannot use keyword '" + name + "' as an identifier.");
} else {
this.unexpected();
}
@@ -2264,9 +2266,6 @@ public class Parser {
if (this.options.ecmaVersion() < 6)
return this.parseIdent(false);
if (this.type == TokenType.name)
return this.parseIdent(false);
if (this.type == TokenType.bracketL) {
Position start = this.startLoc;
this.next();
@@ -2278,8 +2277,7 @@ public class Parser {
if (this.type == TokenType.braceL)
return this.parseObj(true, null);
this.unexpected();
return null;
return this.parseIdent(false);
}
protected List<Expression> parseBindingList(TokenType close, boolean allowEmpty, boolean allowTrailingComma, boolean allowNonIdent) {