hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Add comment explaining kw-only default index upgrade

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2020-05-26 11:15:00 +02:00
parent a616704a56
commit 5a18b08d13
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/upgrades/f635b392038a494915307f913657cd3058f9b476/py_exprs.ql
View File

@@ -139,11 +139,15 @@ where
newidx = oldidx + count(callable.getInnerScope().getArg(_)) - count(args.getDefault(_))
)
or
// expr is a default for a keyword-only parameter
// expr is a default for a keyword-only parameter.
// before this upgrade, we would not always attach the default value to the correct keyword-only parameter,
// to fix this, we calculate the new index based on the source location of the default value (a default value
// must belong to the parameter that was defined immediately before the default value).
exists(Arguments_ args, CallableExprAdjusted callable |
callable.getArgs() = args and
args.getKwDefault(oldidx) = expr and
newidx =
// the last parameter to be defined before this default value
max(int i |
exists(Parameter_ param | param = callable.getInnerScope().getKwonlyarg(i) |
param.getLocation().getStartLine() < expr.getLocation().getStartLine()