hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

revert back to having 2 separate cases in JQuery::MethodCall

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-04-21 13:08:06 +02:00
parent 9fc29ee0f8
commit 59b94b3d1b
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
javascript/ql/src/semmle/javascript/frameworks/jQuery.qll
View File

@@ -538,13 +538,12 @@ module JQuery {
MethodCall() {
this = dollarCall() and name = "$"
or
this = ([dollar(), objectRef()]).getAMemberCall(name)
or
// Handle basic dynamic method dispatch (e.g. `$element[html ? 'html' : 'text'](content)`)
exists(DataFlow::PropRead read | read = this.getCalleeNode() |
read.getBase().getALocalSource() = [dollar(), objectRef()] and
(
read.getPropertyNameExpr().flow().mayHaveStringValue(name) or
read.getPropertyName() = name
)
read.getPropertyNameExpr().flow().mayHaveStringValue(name)
)
or
// Handle contributed JQuery objects that aren't source nodes (usually parameter uses)