hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 08:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add test for reverse DNS from loopback address

Browse Source
This commit is contained in:
Owen Mansel-Chan
2024-06-14 13:53:45 +01:00
parent 098b732937
commit 5973f3fadc
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/ql/test/query-tests/security/CWE-807/semmle/tests/ConditionalBypassTest.java
View File

@@ -49,6 +49,15 @@ class ConditionalBypassTest {
if (Inet4Address.getLocalHost().getCanonicalHostName().equals("localhost")) {
login(user, password);
}
InetAddress loopback = InetAddress.getLoopbackAddress();
// GOOD: reverse DNS on loopback address is fine
if (loopback.getCanonicalHostName().equals("localhost")) {
login(user, password); // $ SPURIOUS: hasConditionalBypassTest
}
if (Inet4Address.getLoopbackAddress().getCanonicalHostName().equals("localhost")) {
login(user, password); // $ SPURIOUS: hasConditionalBypassTest
}
}
public static void test(String user, String password) {