From 595875ff98621ff5138c826cb99a1ae5a2ccc077 Mon Sep 17 00:00:00 2001
From: Erik Krogh Kristensen <erik-krogh@github.com>
Date: Wed, 13 Jul 2022 12:06:12 +0200
Subject: [PATCH] remove redundant not-equals check

---
 java/ql/lib/semmle/code/java/security/OverlyLargeRangeQuery.qll  | 1 -
 .../ql/lib/semmle/javascript/security/OverlyLargeRangeQuery.qll  | 1 -
 python/ql/lib/semmle/python/security/OverlyLargeRangeQuery.qll   | 1 -
 ruby/ql/lib/codeql/ruby/security/OverlyLargeRangeQuery.qll       | 1 -
 4 files changed, 4 deletions(-)

diff --git a/java/ql/lib/semmle/code/java/security/OverlyLargeRangeQuery.qll b/java/ql/lib/semmle/code/java/security/OverlyLargeRangeQuery.qll
index c6d0b41829a..13a5347fdb7 100644
--- a/java/ql/lib/semmle/code/java/security/OverlyLargeRangeQuery.qll
+++ b/java/ql/lib/semmle/code/java/security/OverlyLargeRangeQuery.qll
@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {
   priority = 1 and
   exists(RegExpCharacterRange other |
     reason = "overlaps with " + other + " in the same character class" and
-    result != other and
     rankRange(result) < rankRange(other) and
     overlap(result, other)
   )
diff --git a/javascript/ql/lib/semmle/javascript/security/OverlyLargeRangeQuery.qll b/javascript/ql/lib/semmle/javascript/security/OverlyLargeRangeQuery.qll
index c6d0b41829a..13a5347fdb7 100644
--- a/javascript/ql/lib/semmle/javascript/security/OverlyLargeRangeQuery.qll
+++ b/javascript/ql/lib/semmle/javascript/security/OverlyLargeRangeQuery.qll
@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {
   priority = 1 and
   exists(RegExpCharacterRange other |
     reason = "overlaps with " + other + " in the same character class" and
-    result != other and
     rankRange(result) < rankRange(other) and
     overlap(result, other)
   )
diff --git a/python/ql/lib/semmle/python/security/OverlyLargeRangeQuery.qll b/python/ql/lib/semmle/python/security/OverlyLargeRangeQuery.qll
index c6d0b41829a..13a5347fdb7 100644
--- a/python/ql/lib/semmle/python/security/OverlyLargeRangeQuery.qll
+++ b/python/ql/lib/semmle/python/security/OverlyLargeRangeQuery.qll
@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {
   priority = 1 and
   exists(RegExpCharacterRange other |
     reason = "overlaps with " + other + " in the same character class" and
-    result != other and
     rankRange(result) < rankRange(other) and
     overlap(result, other)
   )
diff --git a/ruby/ql/lib/codeql/ruby/security/OverlyLargeRangeQuery.qll b/ruby/ql/lib/codeql/ruby/security/OverlyLargeRangeQuery.qll
index c6d0b41829a..13a5347fdb7 100644
--- a/ruby/ql/lib/codeql/ruby/security/OverlyLargeRangeQuery.qll
+++ b/ruby/ql/lib/codeql/ruby/security/OverlyLargeRangeQuery.qll
@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {
   priority = 1 and
   exists(RegExpCharacterRange other |
     reason = "overlaps with " + other + " in the same character class" and
-    result != other and
     rankRange(result) < rankRange(other) and
     overlap(result, other)
   )