hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Stop overriding entire module.exports object in test

Browse Source 
Doing `module.exports = blah` prevents other exports from being seen as library inputs.
This commit is contained in:
Asger F
2025-02-12 10:18:24 +01:00
parent f72cd21a55
commit 576dbcb020
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/lib.js
View File

@@ -1,6 +1,6 @@
var cp = require("child_process")
module.exports = function (name) {
module.exports.blah = function (name) {
cp.exec("rm -rf " + name); // $ Alert
cp.execFile(name, [name]);
@@ -19,7 +19,7 @@ function cla() { }
cla.prototype.method = function (name) {
cp.exec("rm -rf " + name); // $ Alert
}
module.exports = new cla();
module.exports.cla = new cla();
function cla2() { }
@@ -474,7 +474,7 @@ const {promisify} = require('util');
const exec = promisify(require('child_process').exec);
module.exports = function check(config) {
module.exports.check = function check(config) {
const cmd = path.join(config.installedPath, 'myBinary -v'); // $ Alert
return exec(cmd);
}