hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Swift: remove IPA classes from cppgen

Browse Source
This commit is contained in:
Paolo Tranquilli
2022-11-15 17:07:52 +01:00
parent f7b5a4d170
commit 56b207e41f
2 changed files with 87 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
swift/codegen/generators/cppgen.py
View File

@@ -80,10 +80,17 @@ class Processor:
trap_name=trap_name,
)
@functools.lru_cache(maxsize=None)
def _is_ipa(self, name: str) -> bool:
cls = self._classmap[name]
return cls.ipa is not None or (
cls.derived and all(self._is_ipa(d) for d in cls.derived))
def get_classes(self):
ret = {'': []}
for k, cls in self._classmap.items():
ret.setdefault(cls.group, []).append(self._get_class(cls.name))
if not self._is_ipa(k):
ret.setdefault(cls.group, []).append(self._get_class(cls.name))
return ret

79
swift/codegen/test/test_cppgen.py
View File

@@ -180,5 +180,84 @@ def test_cpp_skip_pragma(generate):
]
def test_ipa_classes_ignored(generate):
assert generate([
schema.Class(
name="X",
ipa=schema.IpaInfo(from_class="A"),
),
schema.Class(
name="Y",
ipa=schema.IpaInfo(on_arguments={"a": "A", "b": "int"}),
),
schema.Class(
name="Z",
),
]) == [
cpp.Class(name="Z", final=True, trap_name="Zs"),
]
def test_ipa_hierarchy_ignored(generate):
assert generate([
schema.Class(
name="Root",
derived={"Base", "Z"},
),
schema.Class(
name="Base",
bases=["Root"],
derived={"X", "Y"}
),
schema.Class(
name="X",
bases=["Base"],
ipa=schema.IpaInfo(from_class="A"),
),
schema.Class(
name="Y",
bases=["Base"],
ipa=schema.IpaInfo(on_arguments={"a": "A", "b": "int"}),
),
schema.Class(
name="Z",
ipa=schema.IpaInfo(from_class="A"),
),
]) == []
def test_ipa_hierarchy_not_ignored_with_non_ipa_descendant(generate):
root = cpp.Class(name="Root")
base = cpp.Class(name="Base", bases=[root])
assert generate([
schema.Class(
name="Root",
derived={"Base", "Z"},
),
schema.Class(
name="Base",
bases=["Root"],
derived={"X", "Y"}
),
schema.Class(
name="X",
bases=["Base"],
),
schema.Class(
name="Y",
bases=["Base"],
ipa=schema.IpaInfo(on_arguments={"a": "A", "b": "int"}),
),
schema.Class(
name="Z",
ipa=schema.IpaInfo(from_class="A"),
),
]) == [
root,
base,
cpp.Class(name="X", bases=[base], final=True, trap_name="Xes"),
]
if __name__ == '__main__':
sys.exit(pytest.main([__file__] + sys.argv[1:]))