hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 12:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

add query for detecting ignored calls to Array.prototype.concat

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2019-10-10 16:20:27 +02:00
parent 4b27b2ac05
commit 5489a80372
8 changed files with 113 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/test/query-tests/Statements/IgnoreConcatReturn/IgnoreConcatReturn.expected Normal file
View File

@@ -0,0 +1,2 @@
| tst.js:3:1:3:19 | arr.concat([1,2,3]) | Return value from call to concat ignored. |
| tst.js:5:1:5:15 | arr.concat(arr) | Return value from call to concat ignored. |

1
javascript/ql/test/query-tests/Statements/IgnoreConcatReturn/IgnoreConcatReturn.qlref Normal file
View File

@@ -0,0 +1 @@
Statements/IgnoreConcatReturn.ql

13
javascript/ql/test/query-tests/Statements/IgnoreConcatReturn/tst.js Normal file
View File

@@ -0,0 +1,13 @@
var arr = [1,2,3];
arr.concat([1,2,3]); // NOT OK!
arr.concat(arr); // NOT OK!
console.log(arr.concat([1,2,3]));
arr.concat(null);
arr.concat();
arr.concat([]);
({concat: Array.prototype.concat}.concat(arr));