hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

ruby: refine query for uninitialised local variables

Browse Source 
- there are places where uninitialised reads are intentional
- there are also some places where they are impossible
This commit is contained in:
yoff
2025-04-01 13:21:54 +02:00
parent 1ca25b2ccb
commit 53c88da91b
5 changed files with 159 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ruby/ql/test/query-tests/variables/UninitializedLocal/UninitializedLocal.expected
View File

@@ -1,14 +1,3 @@
| UninitializedLocal.rb:12:3:12:3 | m | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:8:7:8:7 | m | m |
| UninitializedLocal.rb:17:16:17:16 | a | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:17:7:17:7 | a | a |
| UninitializedLocal.rb:30:3:30:3 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:31:3:31:3 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:32:3:32:3 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:32:8:32:8 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:33:3:33:3 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:33:14:33:14 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:33:20:33:20 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:34:3:34:3 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:34:15:34:15 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:34:21:34:21 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:7:27:7 | b | b |
| UninitializedLocal.rb:44:13:44:13 | a | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:40:11:40:11 | a | a |
| UninitializedLocal.rb:45:3:45:3 | a | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:40:11:40:11 | a | a |
| UninitializedLocal.rb:34:5:34:5 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:9:27:9 | b | b |
| UninitializedLocal.rb:34:23:34:23 | b | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:27:9:27:9 | b | b |

76
ruby/ql/test/query-tests/variables/UninitializedLocal/UninitializedLocal.rb
View File

@@ -14,33 +14,57 @@ def foo
end
def test_guards
if (a = 3 && a) #$ Alert
a
end
if (a = 3) && a # OK - a is assigned in the previous conjunct
a
end
if !(a = 3) or a # OK - a is assigned in the previous conjunct
a
end
if false
b = 0
end
b.nil?
b || 0 #$ SPURIOUS: Alert
b&.m #$ SPURIOUS: Alert
b if b #$ SPURIOUS: Alert
b.close if b && !b.closed #$ SPURIOUS: Alert
b.blowup if b || !b.blownup #$ Alert
if (a = 3 && a) # OK - a is in a Boolean context
a
end
if (a = 3) && a # OK - a is assigned in the previous conjunct
a
end
if !(a = 3) or a # OK - a is assigned in the previous conjunct
a
end
if false
b = 0
end
b.nil?
b || 0 # OK
b&.m # OK - safe navigation
b if b # OK
b.close if b && !b.closed # OK
b.blowup if b || !b.blownup #$ Alert
if false
c = 0
end
unless c
return
end
c # OK - given above unless
if false
d = 0
end
if (d.nil?)
return
end
d # OK - given above check
if false
e = 0
end
unless (!e.nil?)
return
end
e # OK - given above unless
end
def test_loop
begin
if false
a = 0
else
set_a
end
end until a #$ SPURIOUS: Alert
a #$ SPURIOUS: Alert
begin
if false
a = 0
else
set_a
end
end until a # OK
a # OK - given previous until
end