hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Recognise wrapped chains of replacements.

Browse Source
This commit is contained in:
Max Schaefer
2019-10-30 13:02:59 +00:00
parent 02d16b1dc9
commit 5349e0f881
3 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
javascript/ql/src/Security/CWE-116/DoubleEscaping.ql
View File

@@ -115,6 +115,13 @@ abstract class Replacement extends DataFlow::Node {
result.getOutput() = getASimplePredecessor*(getInput())
}
/**
* Gets the next replacement in this chain of replacements.
*/
Replacement getNextReplacement() {
this = result.getPreviousReplacement()
}
/**
* Gets an earlier replacement in this chain of replacements that
* performs an escaping.
@@ -231,8 +238,8 @@ class WrappedReplacement extends Replacement, DataFlow::CallNode {
WrappedReplacement() {
exists(DataFlow::FunctionNode wrapped | wrapped.getFunction() = getACallee() |
wrapped.getParameter(i).flowsTo(inner.getInput()) and
inner.getOutput().flowsTo(wrapped.getAReturn())
wrapped.getParameter(i).flowsTo(inner.getPreviousReplacement*().getInput()) and
inner.getNextReplacement*().getOutput().flowsTo(wrapped.getAReturn())
)
}

1
javascript/ql/test/query-tests/Security/CWE-116/DoubleEscaping/DoubleEscaping.expected
View File

@@ -9,3 +9,4 @@
| tst.js:86:10:86:22 | JSON.parse(s) | This replacement may produce '\\' characters that are double-unescaped $@. | tst.js:86:10:86:47 | JSON.pa ... g, "<") | here |
| tst.js:99:10:99:66 | s.repla ... &amp;") | This replacement may double-escape '&' characters from $@. | tst.js:99:10:99:43 | s.repla ... epl[c]) | here |
| tst.js:107:10:107:53 | encodeD ... &amp;") | This replacement may double-escape '&' characters from $@. | tst.js:107:10:107:30 | encodeD ... otes(s) | here |
| tst.js:115:10:115:47 | encodeQ ... &amp;") | This replacement may double-escape '&' characters from $@. | tst.js:115:10:115:24 | encodeQuotes(s) | here |

8
javascript/ql/test/query-tests/Security/CWE-116/DoubleEscaping/tst.js
View File

@@ -106,3 +106,11 @@ function encodeDoubleQuotes(s) {
function badWrappedEncode(s) {
return encodeDoubleQuotes(s).replace(/&/g, "&amp;");
}
function encodeQuotes(s) {
return s.replace(/"/g, "&quot;").replace(/'/g, "&apos;");
}
function badWrappedEncode2(s) {
return encodeQuotes(s).replace(/&/g, "&amp;");
}