Merge pull request #2469 from RasmusWL/python-modernise-twisted-library

Python: modernise twisted library

python/ql/test/library-tests/web/twisted/Classes.expected

@@ -0,0 +1,5 @@
+| class MyRequestHandler1 | test.py:3 |
+| class MyRequestHandler2 | test.py:23 |
+| class MyRequestHandler3 | test.py:27 |
+| class MyRequestHandler4 | test.py:38 |
+| class MyRequestHandler5 | test.py:42 |

python/ql/test/library-tests/web/twisted/Classes.ql

@@ -0,0 +1,7 @@
+import python
+import semmle.python.TestUtils
+import semmle.python.web.twisted.Twisted
+
+from ClassValue cls
+where cls = aTwistedRequestHandlerClass()
+select cls.toString(), remove_library_prefix(cls.getScope().getLocation())

python/ql/test/library-tests/web/twisted/Methods.expected

@@ -0,0 +1,8 @@
+| myrender | Function MyRequestHandler2.myrender | test.py:24 |
+| render | Function MyRequestHandler1.render | test.py:4 |
+| render | Function MyRequestHandler3.render | test.py:28 |
+| render | Function MyRequestHandler4.render | test.py:39 |
+| render | Function MyRequestHandler5.render | test.py:43 |
+| render_GET | Function MyRequestHandler1.render_GET | test.py:9 |
+| render_POST | Function MyRequestHandler1.render_POST | test.py:16 |
+| render_POST | Function MyRequestHandler3.render_POST | test.py:31 |

python/ql/test/library-tests/web/twisted/Methods.ql

@@ -0,0 +1,7 @@
+import python
+import semmle.python.TestUtils
+import semmle.python.web.twisted.Twisted
+
+from FunctionValue func, string name
+where func = getTwistedRequestHandlerMethod(name)
+select name, func.toString(), remove_library_prefix(func.getScope().getLocation())

python/ql/test/library-tests/web/twisted/Sinks.expected

@@ -0,0 +1,8 @@
+| test.py:7 | response | externally controlled string |
+| test.py:14 | response | externally controlled string |
+| test.py:21 | response | externally controlled string |
+| test.py:36 | do_stuff_with() | externally controlled string |
+| test.py:40 | Str | externally controlled string |
+| test.py:44 | Str | externally controlled string |
+| test.py:45 | Str | externally controlled string |
+| test.py:46 | Str | externally controlled string |

python/ql/test/library-tests/web/twisted/Sinks.ql

@@ -0,0 +1,10 @@
+import python
+
+import semmle.python.web.HttpRequest
+import semmle.python.web.HttpResponse
+import semmle.python.security.strings.Untrusted
+import semmle.python.TestUtils
+
+from TaintSink sink, TaintKind kind
+where sink.sinks(kind)
+select remove_library_prefix(sink.getLocation()), sink.(ControlFlowNode).getNode().toString(), kind

python/ql/test/library-tests/web/twisted/Sources.expected

@@ -0,0 +1,8 @@
+| test.py:4 | request | twisted.request.http.Request |
+| test.py:9 | request | twisted.request.http.Request |
+| test.py:16 | request | twisted.request.http.Request |
+| test.py:24 | request | twisted.request.http.Request |
+| test.py:28 | myrequest | twisted.request.http.Request |
+| test.py:31 | postrequest | twisted.request.http.Request |
+| test.py:39 | request | twisted.request.http.Request |
+| test.py:43 | request | twisted.request.http.Request |

python/ql/test/library-tests/web/twisted/Sources.ql

@@ -0,0 +1,11 @@
+import python
+import semmle.python.TestUtils
+
+import semmle.python.web.HttpRequest
+import semmle.python.web.HttpResponse
+import semmle.python.security.strings.Untrusted
+
+
+from TaintSource src, TaintKind kind
+where src.isSourceOf(kind)
+select remove_library_prefix(src.getLocation()), src.(ControlFlowNode).getNode().toString(), kind

python/ql/test/library-tests/web/twisted/Taint.expected

@@ -0,0 +1,41 @@
+| test.py:4 | request | twisted.request.http.Request |
+| test.py:5 | Attribute | externally controlled string |
+| test.py:5 | request | twisted.request.http.Request |
+| test.py:6 | request | twisted.request.http.Request |
+| test.py:9 | request | twisted.request.http.Request |
+| test.py:10 | request | twisted.request.http.Request |
+| test.py:11 | Attribute | externally controlled string |
+| test.py:11 | x | twisted.request.http.Request |
+| test.py:12 | request | twisted.request.http.Request |
+| test.py:13 | request | twisted.request.http.Request |
+| test.py:16 | request | twisted.request.http.Request |
+| test.py:17 | Attribute | {[externally controlled string]} |
+| test.py:17 | request | twisted.request.http.Request |
+| test.py:18 | Attribute | {[externally controlled string]} |
+| test.py:18 | Attribute() | [externally controlled string] |
+| test.py:18 | request | twisted.request.http.Request |
+| test.py:19 | Subscript | externally controlled string |
+| test.py:19 | foo | [externally controlled string] |
+| test.py:20 | quux | externally controlled string |
+| test.py:24 | request | twisted.request.http.Request |
+| test.py:25 | request | twisted.request.http.Request |
+| test.py:28 | myrequest | twisted.request.http.Request |
+| test.py:29 | myrequest | twisted.request.http.Request |
+| test.py:31 | postrequest | twisted.request.http.Request |
+| test.py:32 | Attribute() | externally controlled string |
+| test.py:32 | postrequest | twisted.request.http.Request |
+| test.py:33 | Attribute() | externally controlled string |
+| test.py:33 | postrequest | twisted.request.http.Request |
+| test.py:34 | Attribute() | externally controlled string |
+| test.py:34 | postrequest | twisted.request.http.Request |
+| test.py:35 | Attribute() | externally controlled string |
+| test.py:35 | postrequest | twisted.request.http.Request |
+| test.py:36 | w | externally controlled string |
+| test.py:36 | x | externally controlled string |
+| test.py:36 | y | externally controlled string |
+| test.py:36 | z | externally controlled string |
+| test.py:39 | request | twisted.request.http.Request |
+| test.py:40 | request | twisted.request.http.Request |
+| test.py:43 | request | twisted.request.http.Request |
+| test.py:44 | request | twisted.request.http.Request |
+| test.py:45 | request | twisted.request.http.Request |

python/ql/test/library-tests/web/twisted/Taint.ql

@@ -0,0 +1,11 @@
+import python
+import semmle.python.TestUtils
+
+import semmle.python.web.HttpRequest
+import semmle.python.web.HttpResponse
+import semmle.python.security.strings.Untrusted
+
+from TaintedNode node
+
+select remove_library_prefix(node.getLocation()), node.getAstNode().toString(), node.getTaintKind()
+

python/ql/test/library-tests/web/twisted/options

@@ -0,0 +1,2 @@
+semmle-extractor-options: --max-import-depth=1 -p ../../../query-tests/Security/lib/
+optimize: true

python/ql/test/library-tests/web/twisted/test.py

@@ -0,0 +1,51 @@
+from twisted.web import resource
+
+class MyRequestHandler1(resource.Resource):
+    def render(self, request):
+        foo(request.uri)
+        response = do_stuff_with(request)
+        return response
+
+    def render_GET(self, request):
+        x = request
+        bar(x.uri)
+        do_stuff_with(request)
+        response = do_stuff_with(request)
+        return response
+
+    def render_POST(self, request):
+        baz(request.args)
+        foo = request.args.get("baz")
+        quux = foo[5]
+        response = do_stuff_with(quux)
+        return response
+
+class MyRequestHandler2(resource.Resource):
+    def myrender(self, request):
+        do_stuff_with(request)
+
+class MyRequestHandler3(resource.Resource):
+    def render(self, myrequest):
+        do_stuff_with(myrequest)
+
+    def render_POST(self, postrequest):
+        x = postrequest.getHeader("someheader")
+        y = postrequest.getCookie("somecookie")
+        z = postrequest.getUser()
+        w = postrequest.getPassword()
+        return do_stuff_with(x,y,z,w)
+
+class MyRequestHandler4(resource.Resource):
+    def render(self, request):
+        request.write("Foobar")
+
+class MyRequestHandler5(resource.Resource):
+    def render(self, request):
+        request.setHeader("foo", "bar")
+        request.addCookie("key", "value")
+        return "This is my response."
+
+class NotATwistedRequestHandler(object):
+    def render(self, request):
+        return do_stuff_with(request)
+

python/ql/test/query-tests/Security/lib/twisted/web/http.py

@@ -0,0 +1,2 @@
+class Request(object):
+    pass

python/ql/test/query-tests/Security/lib/twisted/web/resource.py

@@ -0,0 +1,2 @@
+class Resource(object):
+    pass