hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #904 from rneatherway/zipslip-fix

Browse Source 
Java: Add a flow step for `Path::toFile` in ZipSlip
This commit is contained in:
Anders Schack-Mulligen
2019-02-11 13:08:38 +01:00
committed by GitHub
parent 10b00254ec 409733838b
commit 52ad816074
3 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/ql/test/query-tests/security/CWE-022/semmle/tests/ZipTest.java
View File

@@ -51,4 +51,13 @@ public class ZipTest {
throw new Exception();
FileOutputStream os = new FileOutputStream(file); // OK
}
public void m6(ZipEntry entry, Path dir) {
String canonicalDest = dir.toFile().getCanonicalPath();
Path target = dir.resolve(entry.getName());
String canonicalTarget = target.toFile().getCanonicalPath();
if (!canonicalTarget.startsWith(canonicalDest + File.separator))
throw new Exception();
OutputStream os = Files.newOutputStream(target); // OK
}
}