From 52a403cc62fcb244118d5f6116a616e36b1c8755 Mon Sep 17 00:00:00 2001 From: Asger F Date: Fri, 12 Apr 2024 11:35:10 +0200 Subject: [PATCH] JS: Address review comments --- .../frameworks/data/internal/ApiGraphModelsExport.qll | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsExport.qll b/javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsExport.qll index 477c0a5d267..3b3b08be31f 100644 --- a/javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsExport.qll +++ b/javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsExport.qll @@ -13,9 +13,13 @@ private import Shared /** * Holds if some proper prefix of `(type, path)` evaluated to `node`, where `remainingPath` * is bound to the suffix of `path` that was not evaluated yet. + * + * See concrete examples in `TypeGraphExport`. */ bindingset[type, path] -predicate partiallyEvaluatedModel(string type, string path, API::Node node, string remainingPath) { +private predicate partiallyEvaluatedModel( + string type, string path, API::Node node, string remainingPath +) { exists(int n, AccessPath accessPath | accessPath = path and getNodeFromPath(type, accessPath, n) = node and