hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: Fix a bug in a unit test

Browse Source 
The 'extractTypeScriptFiles' override did not incorporate the file type and one of our unit tests was expecting this. The test was previously passing for the wrong reasons.
This commit is contained in:
Asger F
2025-06-25 14:30:28 +02:00
parent 02cdde1447
commit 5289e4f424
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
javascript/extractor/test/com/semmle/js/extractor/test/AutoBuildTests.java
View File

@@ -111,12 +111,17 @@ public class AutoBuildTests {
try {
Set<String> actual = new LinkedHashSet<>();
new AutoBuild() {
private void markExtracted(Path file, FileExtractor extractor) {
String extracted = file.toString();
if (extractor.getConfig().hasFileType()) {
extracted += ":" + extractor.getFileType(file.toFile());
}
actual.add(extracted);
}
@Override
protected CompletableFuture<?> extract(FileExtractor extractor, Path file, boolean concurrent) {
String extracted = file.toString();
if (extractor.getConfig().hasFileType())
extracted += ":" + extractor.getFileType(file.toFile());
actual.add(extracted);
markExtracted(file, extractor);
return CompletableFuture.completedFuture(null);
}
@@ -134,7 +139,7 @@ public class AutoBuildTests {
java.util.Set<Path> extractedFiles,
FileExtractors extractors) {
for (Path f : files) {
actual.add(f.toString());
markExtracted(f, extractors.forFile(f));
extractedFiles.add(f);
}
}