hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-23 12:16:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Replace the word 'repetition' with 'position' to properly reflect the semantics of the dbscheme.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-04-04 11:02:55 +01:00
parent 3daefa8b9e
commit 52682e2ccb
3 changed files with 25 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cpp/ql/lib/semmle/code/cpp/exprs/Literal.qll
View File

@@ -208,7 +208,8 @@ class ClassAggregateLiteral extends AggregateLiteral {
/**
* Gets the expression within the aggregate literal that is used to initialize
* field `field` the `repitition`'th time in the initializer list, if present.
* field `field`, if present. The expression is the `position`'th entry in the
* aggregate literal.
*
* For example, if `aggr` represents the initialization literal `{.x = 1234, .x = 5678}` in
* ```cpp
@@ -217,10 +218,10 @@ class ClassAggregateLiteral extends AggregateLiteral {
* ```
* then `aggr.getFieldExpr(x, 0)` gives `1234`, and `aggr.getFieldExpr(x, 1)` gives `5678`.
*/
Expr getFieldExpr(Field field, int repitition) {
Expr getFieldExpr(Field field, int position) {
field = classType.getAField() and
aggregate_field_init(underlyingElement(this), unresolveElement(result), unresolveElement(field),
repitition)
position)
}
/**
@@ -309,7 +310,8 @@ class ArrayOrVectorAggregateLiteral extends AggregateLiteral {
/**
* Gets the expression within the aggregate literal that is used to initialize
* element `elementIndex` the `repitition`'th time in the initializer list, if present.
* element `elementIndex`, if present. The expression is the `position`'th entry
* in the aggregate literal.
*
* For example, if `a` represents the initialization literal `{[0] = 1234, [0] = 5678}` in
* ```cpp
@@ -317,8 +319,8 @@ class ArrayOrVectorAggregateLiteral extends AggregateLiteral {
* ```
* then `a.getElementExpr(0, 0)` gives `1234`, and `a.getElementExpr(0, 1)` gives `5678`.
*/
Expr getElementExpr(int elementIndex, int repitition) {
aggregate_array_init(underlyingElement(this), unresolveElement(result), elementIndex, repitition)
Expr getElementExpr(int elementIndex, int position) {
aggregate_array_init(underlyingElement(this), unresolveElement(result), elementIndex, position)
}
/**