hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Kotlin: Consider ::class type check in equals

Browse Source
This commit is contained in:
Tamas Vajk
2022-10-07 09:22:57 +02:00
parent f7f12076df
commit 51f9314a50
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
View File

@@ -30,6 +30,8 @@ predicate hasTypeTest(Variable v) {
or
any(SafeCastExpr sce).getExpr() = v.getAnAccess()
or
any(ClassExpr c).getExpr() = v.getAnAccess()
or
exists(MethodAccess ma |
ma.getMethod().getName() = "getClass" and
ma.getQualifier() = v.getAnAccess()

1
java/ql/test/kotlin/query-tests/MissingInstanceofInEquals/MissingInstanceofInEquals.expected
View File

@@ -1 +0,0 @@
| Test.kt:10:14:12:5 | equals | This 'equals()' method does not check argument type. |