From 82c0449d56ea1a276570c09471ddd751c4fc7fea Mon Sep 17 00:00:00 2001 From: Ethan Willoner Date: Tue, 6 Dec 2022 00:01:17 +0000 Subject: [PATCH 1/4] Fix bug: In OwinRequest URI should be Uri. --- csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll b/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll index 331e89b1bb8..5f55a77d96b 100644 --- a/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll +++ b/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll @@ -121,7 +121,7 @@ class MicrosoftOwinIOwinRequestClass extends Class { /** Gets the `URI` property. */ Property getUriProperty() { result = this.getAProperty() and - result.hasName("URI") + result.hasName("Uri") } /** DEPRECATED: Alias for getUriProperty */ From b886157f52e5641e1fa84bc241d8f869713e1a2d Mon Sep 17 00:00:00 2001 From: Ethan Willoner Date: Tue, 6 Dec 2022 00:27:17 +0000 Subject: [PATCH 2/4] Add change note. --- csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md. | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md. diff --git a/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md. b/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md. new file mode 100644 index 00000000000..44c50cb1305 --- /dev/null +++ b/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md. @@ -0,0 +1,4 @@ +--- +category: fix +--- +* Fixes a bug where the Owin.qll framework library will look for "URI" instead of "Uri" in the OwinRequest class. \ No newline at end of file From 574d6d611960ac2f1156bc18e70bae687b626967 Mon Sep 17 00:00:00 2001 From: Ethan Willoner Date: Tue, 6 Dec 2022 09:10:22 -0800 Subject: [PATCH 3/4] Fix comment. Co-authored-by: Tom Hvitved --- csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll b/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll index 5f55a77d96b..9d9bf11f91c 100644 --- a/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll +++ b/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll @@ -118,7 +118,7 @@ class MicrosoftOwinIOwinRequestClass extends Class { result.hasName("Scheme") } - /** Gets the `URI` property. */ + /** Gets the `Uri` property. */ Property getUriProperty() { result = this.getAProperty() and result.hasName("Uri") From 64f58061b7bacefdccd95c550b1270715ec5be26 Mon Sep 17 00:00:00 2001 From: Ethan Willoner Date: Tue, 6 Dec 2022 09:13:28 -0800 Subject: [PATCH 4/4] Rename 2022-12-05-owin-uri-fix.md. to 2022-12-05-owin-uri-fix.md --- .../{2022-12-05-owin-uri-fix.md. => 2022-12-05-owin-uri-fix.md} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename csharp/ql/src/change-notes/{2022-12-05-owin-uri-fix.md. => 2022-12-05-owin-uri-fix.md} (63%) diff --git a/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md. b/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md similarity index 63% rename from csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md. rename to csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md index 44c50cb1305..e92df82a41c 100644 --- a/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md. +++ b/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md @@ -1,4 +1,4 @@ --- category: fix --- -* Fixes a bug where the Owin.qll framework library will look for "URI" instead of "Uri" in the OwinRequest class. \ No newline at end of file +* Fixes a bug where the Owin.qll framework library will look for "URI" instead of "Uri" in the OwinRequest class.