hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Dataflow: Address review comments (take 2).

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2024-05-24 13:58:58 +02:00
parent 4ff37cc7b6
commit 51c48c767e
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
View File

@@ -521,6 +521,11 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
private module CallSetOption = Option<CallSets::ValueSet>;
/**
* A set of call sites for which dispatch is affected by the call context.
*
* A `None` value indicates the empty set.
*/
private class CallSet = CallSetOption::Option;
private module DispatchSetsInput implements MkSetsInputSig {
@@ -544,6 +549,15 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
private module DispatchSetsOption = Option<DispatchSets::ValueSet>;
/**
* A set of call edges that are allowed in the call context. This applies to
* all calls in the associated `CallSet`, in particular, this means that if
* a call has no associated edges in the `DispatchSet`, then either all
* edges are allowed or none are depending on whether the call is in the
* `CallSet`.
*
* A `None` value indicates the empty set.
*/
private class DispatchSet = DispatchSetsOption::Option;
private predicate relevantCtx(TCallEdge ctx) {
@@ -795,9 +809,10 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
}
private LocalCallContext getLocalCallContext(CallContext ctx) {
if exists(getUnreachable(ctx))
then result = TSpecificLocalCall(getUnreachable(ctx))
else result instanceof LocalCallContextAny
result = TSpecificLocalCall(getUnreachable(ctx))
or
not exists(getUnreachable(ctx)) and
result instanceof LocalCallContextAny
}
bindingset[cc]