hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 01:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19579 from Napalys/js/dom_property_access

Browse Source 
JS: Improve `useless-expression` query to avoid duplicate alerts on compound expressions
This commit is contained in:
Napalys Klicius
2025-06-10 15:17:13 +02:00
committed by GitHub
parent 791369dd0e e46581163a
commit 51b83dbce5
6 changed files with 47 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/ExprHasNoEffect.expected
View File

@@ -1,3 +1,4 @@
| dom.js:2:33:2:50 | a.clientTop === !0 | This expression has no effect. |
| try.js:22:9:22:26 | x.ordinaryProperty | This expression has no effect. |
| tst2.js:2:4:2:4 | 0 | This expression has no effect. |
| tst.js:3:1:3:2 | 23 | This expression has no effect. |
@@ -11,4 +12,4 @@
| tst.js:50:3:50:36 | new Err ... age(e)) | This expression has no effect. |
| tst.js:61:2:61:20 | o.trivialNonGetter1 | This expression has no effect. |
| tst.js:77:24:77:24 | o | This expression has no effect. |
| uselessfn.js:1:1:1:26 | (functi ... .");\\n}) | This expression has no effect. |
| uselessfn.js:1:2:1:26 | functio ... d.");\\n} | This expression has no effect. |

7
javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/dom.js Normal file
View File

@@ -0,0 +1,7 @@
function f(){
a.clientTop && a.clientTop, a.clientTop === !0; //$Alert
a && a.clientTop;
a.clientTop, a.clientTop;
if(a) return a.clientTop && a.clientTop, a.clientTop === !0;
if(b) return b && (b.clientTop, b.clientTop && b.clientTop), null;
}

5
javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/tst.js
View File

@@ -79,4 +79,9 @@ function g() {
consume(testSomeCondition() ? o :
doSomethingDangerous());
("release" === isRelease() ? warning() : null);
"release" === isRelease() ? warning() : null;
"release" === isRelease() ? warning() : 0;
"release" === isRelease() ? warning() : undefined;
};

2
javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/uselessfn.js
View File

@@ -1,3 +1,3 @@
(function f() { // $ Alert
console.log("I'm never called.");
})
})