Java: Refactor XSS.ql

This commit is contained in:
Anders Schack-Mulligen
2023-03-07 13:33:00 +01:00
parent d839b4038e
commit 50935899fa

View File

@@ -14,25 +14,26 @@
import java import java
import semmle.code.java.dataflow.FlowSources import semmle.code.java.dataflow.FlowSources
import semmle.code.java.security.XSS import semmle.code.java.security.XSS
import DataFlow::PathGraph
class XssConfig extends TaintTracking::Configuration { module XssConfig implements DataFlow::ConfigSig {
XssConfig() { this = "XSSConfig" } predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
override predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource } predicate isSink(DataFlow::Node sink) { sink instanceof XssSink }
override predicate isSink(DataFlow::Node sink) { sink instanceof XssSink } predicate isBarrier(DataFlow::Node node) { node instanceof XssSanitizer }
override predicate isSanitizer(DataFlow::Node node) { node instanceof XssSanitizer } predicate isBarrierOut(DataFlow::Node node) { node instanceof XssSinkBarrier }
override predicate isSanitizerOut(DataFlow::Node node) { node instanceof XssSinkBarrier } predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) {
override predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) {
any(XssAdditionalTaintStep s).step(node1, node2) any(XssAdditionalTaintStep s).step(node1, node2)
} }
} }
from DataFlow::PathNode source, DataFlow::PathNode sink, XssConfig conf module XssFlow = TaintTracking::Make<XssConfig>;
where conf.hasFlowPath(source, sink)
import XssFlow::PathGraph
from XssFlow::PathNode source, XssFlow::PathNode sink
where XssFlow::hasFlowPath(source, sink)
select sink.getNode(), source, sink, "Cross-site scripting vulnerability due to a $@.", select sink.getNode(), source, sink, "Cross-site scripting vulnerability due to a $@.",
source.getNode(), "user-provided value" source.getNode(), "user-provided value"