hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Extract override modifier

Browse Source
This commit is contained in:
Tamas Vajk
2022-04-07 09:30:03 +02:00
committed by Ian Lynagh
parent 92de139805
commit 505ccbbcf6
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/ql/src/Advisory/Declarations/MissingOverrideAnnotation.ql
View File

@@ -21,6 +21,7 @@ from OverridingMethod m, Method overridden
where
m.fromSource() and
m.overrides(overridden) and
not m.hasModifier("override") and
not m.isOverrideAnnotated() and
not exists(FunctionalExpr mref | mref.asMethod() = m)
select m, "This method overrides $@; it is advisable to add an Override annotation.", overridden,

3
java/ql/test/kotlin/query-tests/MissingOverrideAnnotation/MissingOverrideAnnotation.expected
View File

@@ -1,3 +0,0 @@
| Test.kt:16:14:18:5 | m | This method overrides $@; it is advisable to add an Override annotation. | Test.kt:2:10:4:5 | m | A.m |
| Test.kt:22:14:22:24 | o | This method overrides $@; it is advisable to add an Override annotation. | Test.kt:12:5:12:11 | o | I.o |
| Test.kt:24:14:24:22 | getP | This method overrides $@; it is advisable to add an Override annotation. | Test.kt:8:10:8:18 | getP | A.getP |