hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Only add explicit interface implementation to the generated stub if it is unique.

Browse Source
This commit is contained in:
Michael Nebel
2023-02-24 11:32:41 +01:00
parent 5ba59fc9a8
commit 50570dc3ee
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
csharp/ql/src/Stubs/Stubs.qll
View File

@@ -400,7 +400,7 @@ private string stubAccessibility(Member m) {
if
m.getDeclaringType() instanceof Interface
or
exists(m.(Virtualizable).getExplicitlyImplementedInterface())
exists(getSingleSpecificImplementedInterface(m))
or
m instanceof Constructor and m.isStatic()
then result = ""
@@ -713,9 +713,13 @@ private string stubEventAccessors(Event e) {
else result = ";"
}
private Interface getSingleSpecificImplementedInterface(Member c) {
result = unique(Interface i | i = c.(Virtualizable).getExplicitlyImplementedInterface())
}
private string stubExplicitImplementation(Member c) {
if exists(c.(Virtualizable).getExplicitlyImplementedInterface())
then result = stubClassName(c.(Virtualizable).getExplicitlyImplementedInterface()) + "."
if exists(getSingleSpecificImplementedInterface(c))
then result = stubClassName(getSingleSpecificImplementedInterface(c)) + "."
else result = ""
}