hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'master' into pseudo-random-bytes

Browse Source
This commit is contained in:
Max Schaefer
2018-12-12 08:19:57 +00:00
committed by GitHub
parent a01a9dc5cc 06dd5f3616
commit 4fc27aaa51
22 changed files with 92 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
javascript/ql/test/query-tests/AngularJS/DuplicateDependency/DuplicateDependency.expected
View File

@@ -1,4 +1,5 @@
| duplicates.js:2:5:2:18 | function f(){} | This function has a duplicate dependency '$@'. | duplicates.js:3:26:3:31 | 'dup5' | dup5 |
| duplicates.js:6:14:6:57 | ['dup2a ... p2b){}] | This function has a duplicate dependency '$@'. | duplicates.js:6:24:6:30 | 'dup2a' | dup2a |
| duplicates.js:7:14:7:57 | ['dup3b ... p3b){}] | This function has a duplicate dependency '$@'. | duplicates.js:7:24:7:30 | 'dup3b' | dup3b |
| duplicates.js:8:14:8:79 | ['dup4' ... p4C){}] | This function has a duplicate dependency '$@'. | duplicates.js:8:35:8:40 | 'dup4' | dup4 |
| duplicates.js:6:33:6:56 | functio ... up2b){} | This function has a duplicate dependency '$@'. | duplicates.js:6:24:6:30 | 'dup2a' | dup2a |
| duplicates.js:7:33:7:56 | functio ... up3b){} | This function has a duplicate dependency '$@'. | duplicates.js:7:24:7:30 | 'dup3b' | dup3b |
| duplicates.js:8:43:8:78 | functio ... up4C){} | This function has a duplicate dependency '$@'. | duplicates.js:8:35:8:40 | 'dup4' | dup4 |
| duplicates.js:15:35:15:112 | functio ... } | This function has a duplicate dependency '$@'. | duplicates.js:15:25:15:32 | 'dup11a' | dup11a |

2
javascript/ql/test/query-tests/AngularJS/DuplicateDependency/duplicates.js
View File

@@ -12,5 +12,7 @@
.run(['notDup8a', 'notDup8b', function(notDup8a, notDup8b){}]) // OK
.run(['notDup9a', 'notDup9b', function(notDup9c, notDup9d){}]) // OK
.run(['dup10a', 'dup10a', 'dup10a', function(dup10a, dup10a, dup10a){}]) // OK (flagged by js/duplicate-parameter-name)
.run(['dup11a', 'dup11a', function(dup11a, dup11b){ // NOT OK (alert formatting for multi-line function)
}])
;
})();

2
javascript/ql/test/query-tests/AngularJS/RepeatedInjection/RepeatedInjection.expected
View File

@@ -2,3 +2,5 @@
| repeated-injection.js:6:5:6:31 | functio ... name){} | This function has $@ defined in multiple places. | repeated-injection.js:8:54:8:73 | ['name', $Injected2] | dependency injections |
| repeated-injection.js:10:5:10:31 | functio ... name){} | This function has $@ defined in multiple places. | repeated-injection.js:11:5:11:22 | $Injected3.$inject | dependency injections |
| repeated-injection.js:10:5:10:31 | functio ... name){} | This function has $@ defined in multiple places. | repeated-injection.js:12:5:12:22 | $Injected3.$inject | dependency injections |
| repeated-injection.js:33:5:33:84 | functio ... )\\n } | This function has $@ defined in multiple places. | repeated-injection.js:35:5:35:23 | $Injected10.$inject | dependency injections |
| repeated-injection.js:33:5:33:84 | functio ... )\\n } | This function has $@ defined in multiple places. | repeated-injection.js:36:56:36:76 | ['name' ... cted10] | dependency injections |

5
javascript/ql/test/query-tests/AngularJS/RepeatedInjection/repeated-injection.js
View File

@@ -30,4 +30,9 @@
angular.module('app9').controller('controller9', ['name', function inline9(name){}]); // OK
function $Injected10(name){ // NOT OK (alert formatting for multi-line function)
}
$Injected10.$inject = ['name'];
angular.module('app10').controller('controller10', ['name', $Injected10]);
})();

1
javascript/ql/test/query-tests/AngularJS/UnusedAngularDependency/UnusedAngularDependency.expected
View File

@@ -2,3 +2,4 @@
| unused-angular-dependency.js:14:14:14:39 | ["unuse ... n() {}] | This function has 0 parameters, but 1 dependency is injected into it. |
| unused-angular-dependency.js:16:14:16:53 | ["used2 ... d2) {}] | This function has 1 parameter, but 2 dependencies are injected into it. |
| unused-angular-dependency.js:17:14:17:52 | ["unuse ... n() {}] | This function has 0 parameters, but 2 dependencies are injected into it. |
| unused-angular-dependency.js:18:14:18:105 | ["used2 ... }] | This function has 1 parameter, but 2 dependencies are injected into it. |

2
javascript/ql/test/query-tests/AngularJS/UnusedAngularDependency/unused-angular-dependency.js
View File

@@ -15,6 +15,8 @@
.run(f2)
.run(["used2", "unused9", function(used2) {}]) // NOT OK
.run(["unused10", "unused11", function() {}]) // NOT OK
.run(["used2", "unused12", function(used2) { // NOT OK (alert formatting for multi-line function)
}])
;
})();
angular.module('app2')

6
javascript/ql/test/query-tests/Declarations/UnusedParameter/tst.js
View File

@@ -33,4 +33,8 @@ var g = f3;
// OK
define(function (require, exports, module) {
module.x = 23;
});
});
// OK: starts with underscore
function f(_p) {
}

2
javascript/ql/test/query-tests/Declarations/UnusedVariable/UnusedVariable.expected
View File

@@ -9,5 +9,7 @@
| multi-imports.js:2:1:2:42 | import ... om 'x'; | Unused imports alphabetically, ordered. |
| require-react-in-other-scope.js:2:9:2:13 | React | Unused variable React. |
| typeoftype.ts:9:7:9:7 | y | Unused variable y. |
| underscore.js:6:7:6:7 | e | Unused variable e. |
| underscore.js:7:7:7:7 | f | Unused variable f. |
| unusedShadowed.ts:1:1:1:26 | import ... where'; | Unused import T. |
| unusedShadowed.ts:2:1:2:31 | import ... where'; | Unused import object. |

10
javascript/ql/test/query-tests/Declarations/UnusedVariable/underscore.js Normal file
View File

@@ -0,0 +1,10 @@
function f(a) {
const [a, // OK: used
_, // OK: starts with underscore
_c, // OK: starts with underscore
d, // OK: used
e, // NOT OK
f] // NOT OK
= a;
return a + d;
}