C++: Don't generate WriteSideEffect instructions for const parameter indirections.

2026-05-03 12:45:27 +02:00 · 2021-02-19 15:15:51 +01:00
parent d490bea9a9
commit 4f23c3546f
2 changed files with 395 additions and 457 deletions
--- a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll
+++ b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll
@@ -658,14 +658,18 @@ newtype TTranslatedElement =
        t instanceof ReferenceType
      ) and
      (
-        isWrite = true or
+        isWrite = true and
+        not call.getTarget().getParameter(n).getType().isDeeplyConstBelow()
+        or
        isWrite = false
      )
      or
      not call.getTarget() instanceof SideEffectFunction and
      n = -1 and
      (
-        isWrite = true or
+        isWrite = true and
+        not call.getTarget() instanceof ConstMemberFunction
+        or
        isWrite = false
      )
    ) and
--- a/cpp/ql/test/library-tests/ir/ir/raw_ir.expected
+++ b/cpp/ql/test/library-tests/ir/ir/raw_ir.expected