From 4f1d6f472d474e69782c9c3c7902022bc93e5793 Mon Sep 17 00:00:00 2001 From: Chad Bentz <1760475+felickz@users.noreply.github.com> Date: Mon, 15 Jun 2026 11:34:43 -0400 Subject: [PATCH] Fix test comments: replace GOOD/BAD markers with flow source descriptions Per review feedback, GOOD/BAD markers don't apply to flow source enumeration tests. Use descriptive comments instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../dataflow/flowsources/aspremote/AspRemoteFlowSource.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/csharp/ql/test/library-tests/dataflow/flowsources/aspremote/AspRemoteFlowSource.cs b/csharp/ql/test/library-tests/dataflow/flowsources/aspremote/AspRemoteFlowSource.cs index 8507d60cd39..5bc8025f231 100644 --- a/csharp/ql/test/library-tests/dataflow/flowsources/aspremote/AspRemoteFlowSource.cs +++ b/csharp/ql/test/library-tests/dataflow/flowsources/aspremote/AspRemoteFlowSource.cs @@ -67,7 +67,7 @@ namespace Testing // Razor Page handler tests public class MyPageModel : Microsoft.AspNetCore.Mvc.RazorPages.PageModel { - // BAD: handler method parameters are user-controlled + // Handler method parameters are remote flow sources public void OnGet(string id) { } public void OnPost(string command, int count) { } @@ -78,10 +78,10 @@ namespace Testing public void OnDelete(string itemId) { } - // GOOD: not a handler method (doesn't start with On) + // Not a handler method — does not start with "On", so not a flow source public void GetUser(string userId) { } - // GOOD: marked with NonHandler attribute + // Excluded by [NonHandler] attribute, so not a flow source [Microsoft.AspNetCore.Mvc.RazorPages.NonHandlerAttribute] public void OnGetNonHandler(string param) { } }