hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: permit some calls with spurious arguments to empty functions

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-08-08 10:13:02 +02:00
parent 87f9ecb442
commit 4e98ce21b4
7 changed files with 66 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
javascript/ql/src/LanguageFeatures/SpuriousArguments.ql
View File

@@ -83,5 +83,14 @@ class SpuriousArguments extends Expr {
from SpuriousArguments args, Function f, string arguments
where f = args.getCall().getACallee() and
if args.getCount() = 1 then arguments = "argument" else arguments = "arguments"
if args.getCount() = 1 then arguments = "argument" else arguments = "arguments" and
(
// exclude empty functions, they are probably commented out debug utilities ...
exists(f.getABodyStmt()) or
// ... but include: constructors, arrows and externals/ambients
f instanceof Constructor or // unlikely to be a debug utility
f instanceof ArrowFunctionExpr or // cannot be empty
f instanceof ExternalFunction or // always empty
f.isAmbient() // always empty
)
select args, "Superfluous " + arguments + " passed to $@.", f, f.describe()