From 4e70e674fdc5634852521533c604b8946b1d3692 Mon Sep 17 00:00:00 2001 From: Cornelius Riemenschneider Date: Mon, 6 Nov 2023 23:26:21 +0100 Subject: [PATCH] Revert "Java: Make integration test more robust wrt recent Java versions." This reverts commit ae21bbf0b2c67a8a6d6031c9223ccad318fd52f2. --- .../diagnostics/java-version-too-old/test.py | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/java/ql/integration-tests/all-platforms/java/diagnostics/java-version-too-old/test.py b/java/ql/integration-tests/all-platforms/java/diagnostics/java-version-too-old/test.py index e211786c43b..1cb00f89f55 100644 --- a/java/ql/integration-tests/all-platforms/java/diagnostics/java-version-too-old/test.py +++ b/java/ql/integration-tests/all-platforms/java/diagnostics/java-version-too-old/test.py @@ -3,16 +3,14 @@ from create_database_utils import * from diagnostics_test_utils import * # Ensure we're using an old Java version that won't work with Gradle -for java_home in ["JAVA_HOME_8_X64", "JAVA_HOME_8_arm64", "JAVA_HOME_8_ARM64"]: - if java_home in os.environ: - os.environ["JAVA_HOME"] = os.environ[java_home] - sep = ";" if platform.system() == "Windows" else ":" - os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]]) - break +if "JAVA_HOME_8_X64" in os.environ: + os.environ["JAVA_HOME"] = os.environ["JAVA_HOME_8_X64"] + sep = ";" if platform.system() == "Windows" else ":" + os.environ["PATH"] = "".join([os.path.join(os.environ["JAVA_HOME"], "bin"), sep, os.environ["PATH"]]) -# Ensure the autobuilder *doesn't* see newer Java versions, which it could switch to in order to build the project: -for k in os.environ: - if re.match(r"^JAVA_HOME_\d\d_", k): +# Ensure the autobuilder *doesn't* see Java 11 or 17, which it could switch to in order to build the project: +for k in ["JAVA_HOME_11_X64", "JAVA_HOME_17_X64"]: + if k in os.environ: del os.environ[k] # Use a custom, empty toolchains.xml file so the autobuilder doesn't see any Java versions that may be